Revert "Add net autoselectfamily default test (#19970)"#20028
Closed
Revert "Add net autoselectfamily default test (#19970)"#20028
Conversation
This reverts PR #19970 since it seems to be the one that broke test-http-pipeline-requests-connection-leak
Collaborator
|
Updated 2:53 PM PT - May 29th, 2025
❌ @190n, your commit b500e10 has 3 failures in
🧪 To try this PR locally: bunx bun-pr 20028That installs a local version of the PR into your bun-20028 --bun |
Contributor
Author
|
Never mind, it failed on this too so I was wrong about what caused this. It does seem to have been flaky even since before #18962. For example it timed out here: https://buildkite.com/bun/bun/builds/16783. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This reverts PR #19970 since it seems to be the one that broke test-http-pipeline-requests-connection-leak:
(The diff on
net.tshere is smaller than in #19970 since the rest of #19970 was already reverted in #20002)How did you verify your code works?
Will see what CI says