Skip to content

Revert "Add net autoselectfamily default test (#19970)"#20028

Closed
190n wants to merge 1 commit intomainfrom
ben/revert-19970
Closed

Revert "Add net autoselectfamily default test (#19970)"#20028
190n wants to merge 1 commit intomainfrom
ben/revert-19970

Conversation

@190n
Copy link
Contributor

@190n 190n commented May 29, 2025

What does this PR do?

This reverts PR #19970 since it seems to be the one that broke test-http-pipeline-requests-connection-leak:

(The diff on net.ts here is smaller than in #19970 since the rest of #19970 was already reverted in #20002)

How did you verify your code works?

Will see what CI says

This reverts PR #19970 since it seems to be the one that broke test-http-pipeline-requests-connection-leak
@robobun
Copy link
Collaborator

robobun commented May 29, 2025

Updated 2:53 PM PT - May 29th, 2025

@190n, your commit b500e10 has 3 failures in Build #17638:


🧪   To try this PR locally:

bunx bun-pr 20028

That installs a local version of the PR into your bun-20028 executable, so you can run:

bun-20028 --bun

@190n
Copy link
Contributor Author

190n commented May 29, 2025

Never mind, it failed on this too so I was wrong about what caused this.

It does seem to have been flaky even since before #18962. For example it timed out here: https://buildkite.com/bun/bun/builds/16783.

@190n 190n closed this May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants