Skip to content

update published npm binaries package#20945

Open
RiskyMH wants to merge 5 commits intomainfrom
riskymh/npm-publish-upd
Open

update published npm binaries package#20945
RiskyMH wants to merge 5 commits intomainfrom
riskymh/npm-publish-upd

Conversation

@RiskyMH
Copy link
Contributor

@RiskyMH RiskyMH commented Jul 10, 2025

add some missing README's, fix the package description, and hopefully make musl not downloaded for linux by default (unless its needed)

also adds a test that was removed in #10157 (the windows one didn't work because of the download ci bun)

@robobun
Copy link
Collaborator

robobun commented Jul 10, 2025

Updated 3:07 AM PT - Jul 16th, 2025

@Jarred-Sumner, your commit 77324cc is building: #20726

RiskyMH added 2 commits July 11, 2025 03:18
add some missing README's, fix the package description, and hopefully make musl not downloaded for linux by default (unless its needed)
@RiskyMH RiskyMH force-pushed the riskymh/npm-publish-upd branch from 1963500 to 09ac293 Compare July 10, 2025 17:18
Comment on lines -268 to +278
await $`${{ raw: install }} ./bun-${version}.tgz`;
const nodePath = Bun.which("node")?.replace("/node", "") || "";
await $`${{ raw: install }} ./bun-${version}.tgz`.env({
PATH: nodePath ? `${nodePath}:${process.env.PATH}` : process.env.PATH,
});
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why it throws env: node: No such file or directory without this force path change...

["yarn set version berry; yarn add", "yarn"],
["yarn set version latest; yarn add", "yarn"],
["pnpm i", "pnpm"],
["pnpm i --dangerously-allow-all-builds", "pnpm"],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pnpm seems to also have a postinstall blocking now too

 Warning ─────────────────────────────────────────────────────────────────────╮
                                                                              
   Ignored build scripts: bun.                                                
   Run "pnpm approve-builds" to pick which dependencies should be allowed     
   to run scripts.                                                            
                                                                              
╰──────────────────────────────────────────────────────────────────────────────╯

@RiskyMH RiskyMH requested a review from Jarred-Sumner July 12, 2025 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants