-
Notifications
You must be signed in to change notification settings - Fork 4k
fix(serve): allow server config with stop method to auto-start #26748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
robobun
wants to merge
1
commit into
main
Choose a base branch
from
claude/fix-26747-server-stop-method
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+79
−2
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| import { expect, test } from "bun:test"; | ||
| import { bunEnv, bunExe, tempDir } from "harness"; | ||
|
|
||
| // https://github.com/oven-sh/bun/issues/26747 | ||
| // Server config objects with a `stop` method should still auto-start. | ||
| // The previous fix for #26142 incorrectly used the presence of a `stop` method | ||
| // to detect Server instances, but user config objects (like Elysia apps) can | ||
| // legitimately have a `stop` method. | ||
|
|
||
| test("server config with stop method as default export should auto-start", async () => { | ||
| using dir = tempDir("issue-26747", { | ||
| "server.js": ` | ||
| // Export a config object with a stop method | ||
| // This should still trigger auto-start | ||
| export default { | ||
| port: 0, | ||
| fetch(req) { | ||
| return new Response("Hello from server with stop method"); | ||
| }, | ||
| stop() { | ||
| // Custom stop method - should not prevent auto-start | ||
| }, | ||
| }; | ||
|
|
||
| // Force the process to exit after 100ms so the test can verify the startup message | ||
| // without the server blocking forever | ||
| setTimeout(() => process.exit(0), 100); | ||
| `, | ||
| }); | ||
|
|
||
| await using proc = Bun.spawn({ | ||
| cmd: [bunExe(), "server.js"], | ||
| env: bunEnv, | ||
| cwd: String(dir), | ||
| stdout: "pipe", | ||
| stderr: "pipe", | ||
| }); | ||
|
|
||
| const [stdout, stderr, exitCode] = await Promise.all([proc.stdout.text(), proc.stderr.text(), proc.exited]); | ||
|
|
||
| // Should have started the server (look for the debug message on stdout) | ||
| expect(stdout).toContain("Started"); | ||
| expect(exitCode).toBe(0); | ||
| }); | ||
|
|
||
| test("server config with both stop and reload methods should not auto-start", async () => { | ||
| // A config object with a `reload` method is likely a Server instance | ||
| // or something that manages itself, so we should not auto-start it | ||
| using dir = tempDir("issue-26747-reload", { | ||
| "server.js": ` | ||
| export default { | ||
| port: 0, | ||
| fetch(req) { | ||
| return new Response("Hello"); | ||
| }, | ||
| stop() {}, | ||
| reload() {}, | ||
| }; | ||
| console.log("Script completed without auto-starting"); | ||
| `, | ||
| }); | ||
|
|
||
| await using proc = Bun.spawn({ | ||
| cmd: [bunExe(), "server.js"], | ||
| env: bunEnv, | ||
| cwd: String(dir), | ||
| stdout: "pipe", | ||
| stderr: "pipe", | ||
| }); | ||
|
|
||
| const [stdout, stderr, exitCode] = await Promise.all([proc.stdout.text(), proc.stderr.text(), proc.exited]); | ||
|
|
||
| // Should NOT have started the server because it has a reload method | ||
| expect(stdout).not.toContain("Started"); | ||
| expect(stdout).toContain("Script completed without auto-starting"); | ||
| expect(exitCode).toBe(0); | ||
| }); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.