Skip to content

fix(s3): rename checksumAlgorithme to checksumAlgorithm#26760

Open
FrankFMY wants to merge 1 commit intooven-sh:mainfrom
FrankFMY:fix-s3-checksum-typo
Open

fix(s3): rename checksumAlgorithme to checksumAlgorithm#26760
FrankFMY wants to merge 1 commit intooven-sh:mainfrom
FrankFMY:fix-s3-checksum-typo

Conversation

@FrankFMY
Copy link

@FrankFMY FrankFMY commented Feb 5, 2026

Summary

  • Fix typo in S3ListObjectsResponse.contents where the property name used the French spelling checksumAlgorithme instead of the correct checksumAlgorithm
  • Renamed the Zig struct field, local variables, and the JavaScript property name to match the TypeScript type definition and AWS S3 API specification

Fixes #19142

Fix typo in S3ListObjectsResponse where the property name was
using the French spelling "checksumAlgorithme" instead of the
correct "checksumAlgorithm", matching the TypeScript type definition
and AWS S3 API specification.

Fixes oven-sh#19142
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 5, 2026

Walkthrough

The PR corrects a typo in the S3 list objects functionality by renaming the struct field from checksum_algorithme to checksum_algorithm. This change is propagated through parsing logic, JavaScript translation, and object construction.

Changes

Cohort / File(s) Summary
S3 List Objects Typo Fix
src/s3/list_objects.zig
Renamed struct field checksum_algorithme to checksum_algorithm in S3ListObjectsContents. Updated XML parsing to assign ChecksumAlgorithm element to the renamed field, JS translation to use corrected key name, and object construction to reference the corrected field name.
🚥 Pre-merge checks | ✅ 3 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete. It lacks the required template sections 'What does this PR do?' and 'How did you verify your code works?' Add the missing sections from the template: describe what the PR does and include verification steps to confirm the fix works correctly.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and concisely describes the main change: renaming a misspelled field from checksumAlgorithme to checksumAlgorithm.
Linked Issues check ✅ Passed The PR successfully addresses issue #19142 by renaming the misspelled field from checksumAlgorithme to checksumAlgorithm throughout the codebase, matching the TypeScript types and AWS S3 API specification.
Out of Scope Changes check ✅ Passed All changes are directly related to fixing the typo in the checksum algorithm field name as specified in issue #19142; no out-of-scope modifications detected.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo in property name S3ListObjectsResponse.contents.checksumAlgorithm**E**

1 participant