fix(fetch): use specific error message when URL has no hostname#26761
Open
FrankFMY wants to merge 1 commit intooven-sh:mainfrom
Open
fix(fetch): use specific error message when URL has no hostname#26761FrankFMY wants to merge 1 commit intooven-sh:mainfrom
FrankFMY wants to merge 1 commit intooven-sh:mainfrom
Conversation
When fetch() receives a URL that parses but has no hostname (e.g.
`fetch("/some_path")`), it previously showed the misleading message
"URL must not be a blank string". Now it shows "URL must have a
hostname" which accurately describes the problem.
Fixes oven-sh#21361
Contributor
WalkthroughA new error message constant was introduced and applied to provide a more precise error when a URL lacks a hostname during fetch preconnect operations, replacing a generic blank string error. Changes
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetch()receives a URL that parses but has no hostname (e.g.fetch("/some_path"),fetch(123)), it showed "URL must not be a blank string" which is misleadingfetch_error_no_hostname= "fetch() URL must have a hostname." and use it for the hostname checkfetch_error_blank_urlmessage is still used when the URL string is actually emptyFixes #21361