Merged
Conversation
Collaborator
|
Hi @HammadYousaf01, can we rebase this PR and resolve the CI if this needs to be merged OR else we can convert it to draft. |
Faraz32123
force-pushed
the
hammad/dark-theme-logo-support
branch
5 times, most recently
from
88affd1 to
cd8b22b
Compare
HammadYousaf01
force-pushed
the
hammad/dark-theme-logo-support
branch
from
697493d to
d9da033
Compare
Faraz32123
force-pushed
the
hammad/dark-theme-logo-support
branch
from
d9da033 to
2da0c76
Compare
Faraz32123
force-pushed
the
hammad/dark-theme-logo-support
branch
from
2da0c76 to
f5348d0
Compare
github-project-automation
bot
moved this from In Progress
to Done
in Tutor project management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces full support for dark-theme logos. A new logo-white.png asset is added and used for the dark theme. The application automatically serves the dark-theme logo in dark mode across both legacy templates and MFEs. If the dark logo asset is not available, duplicate the existing logo and rename it to logo-white.png, so that the same logo would appear in both dark and light mode.