Skip to content

feat: refactor & make indigo patches more readable#202

Merged
Faraz32123 merged 1 commit intoreleasefrom
feat/refactor_and_simplify_indigo_patches_structure_for_react_components
Feb 17, 2026
Merged

feat: refactor & make indigo patches more readable#202
Faraz32123 merged 1 commit intoreleasefrom
feat/refactor_and_simplify_indigo_patches_structure_for_react_components

Conversation

@Faraz32123
Copy link
Collaborator

@Faraz32123 Faraz32123 self-assigned this Feb 16, 2026
@Faraz32123 Faraz32123 requested review from HammadYousaf01 and ahmed-arb and removed request for ahmed-arb February 16, 2026 08:33
@Faraz32123 Faraz32123 requested a review from ahmed-arb February 16, 2026 08:33
@Faraz32123 Faraz32123 moved this from Pending Triage to In review in Tutor project management Feb 16, 2026
- refactor, simplify & make indigo patches more readable
- separate react components from patches folder and render them cleanly, this also improve development of react components in jsx files instead of patches.
@Faraz32123 Faraz32123 force-pushed the feat/refactor_and_simplify_indigo_patches_structure_for_react_components branch from cb614db to aab46e3 Compare February 16, 2026 08:36
Copy link
Contributor

@ahmed-arb ahmed-arb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Faraz32123, this is a much-needed upgrade 👍

One question though: do we really need the mfe-env-config-buildtime-imports patch component? At the moment, I don’t see a strong case for having multiple import patches. If we’re only going to maintain a single import, it might be simpler and more maintainable to keep the imports directly inside the patch itself rather than abstracting them into a separate component.

@Faraz32123
Copy link
Collaborator Author

Faraz32123 commented Feb 16, 2026

Thanks @Faraz32123, this is a much-needed upgrade 👍

👍 Thanks,

One question though: do we really need the mfe-env-config-buildtime-imports patch component? At the moment, I don’t see a strong case for having multiple import patches. If we’re only going to maintain a single import, it might be simpler and more maintainable to keep the imports directly inside the patch itself rather than abstracting them into a separate component.

I understand your concern. But it's more about readability and keeping the react components & their imports in same directory without any warnings & formatting errors.
If we see Example.jsx file. It says, add your imports to Imports.jsx which doesn't give import warning like mfe-env-config-buildtime-imports patch. And we can't remove mfe-env-config-buildtime-imports patch due to backward compatibilty i.e. if some people are using this patch.

Screenshot 2026-02-16 at 5 40 26 PM Screenshot 2026-02-16 at 5 40 38 PM

@Faraz32123 Faraz32123 merged commit 3b3297e into release Feb 17, 2026
1 check passed
@Faraz32123 Faraz32123 deleted the feat/refactor_and_simplify_indigo_patches_structure_for_react_components branch February 17, 2026 11:07
@github-project-automation github-project-automation bot moved this from In review to Done in Tutor project management Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Refactor & simplify tutor-indigo patches and move react components out of patches

2 participants