Skip to content

fix: Adaptive Logo Styling for Different Sizes and Dimensions#209

Merged
arbirali merged 2 commits intoreleasefrom
rahat/adaptive-logo-height
Mar 24, 2026
Merged

fix: Adaptive Logo Styling for Different Sizes and Dimensions#209
arbirali merged 2 commits intoreleasefrom
rahat/adaptive-logo-height

Conversation

@arbirali
Copy link
Collaborator

@arbirali arbirali commented Mar 19, 2026

This PR includes the refactored code for the following changes.

  • Restyle the header logo for adaptive height so that logos with different dimensions would appear normal.
  • Restyle the footer nav link, making it right-aligned in the larger screens.
Before After
image image
image image

@Faraz32123
Copy link
Collaborator

Can you add some more images in description that actually tells how it was before & after this PR change.

@Faraz32123 Faraz32123 moved this from Pending Triage to In review in Tutor project management Mar 19, 2026
@arbirali
Copy link
Collaborator Author

@Faraz32123, I have updated the screenshots. Please review.

@Faraz32123
Copy link
Collaborator

@Faraz32123, I have updated the screenshots. Please review.

Can you also attach Screenshots for MFE experience?
And isn't the logo size seems too large? Can we also check it with height: 36px; or height: 40px;?

@arbirali
Copy link
Collaborator Author

The MFE's Screenshots are attached with their relevant PR here
We can also reduce the logo's height by adding spacing to its PNG image.
Decreasing the height will cause an issue with a square PNG logo. Its dimensions will not fit in the decreased height.
image

@arbirali arbirali merged commit 45bc627 into release Mar 24, 2026
1 check passed
@arbirali arbirali deleted the rahat/adaptive-logo-height branch March 24, 2026 09:39
@github-project-automation github-project-automation bot moved this from In review to Done in Tutor project management Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

3 participants