Open
Conversation
- Verify ShivaUnwind event is emitted immediately before LoanSettled - Only modify realizedPnlOvl/realizedPnlStables if ordering is correct - Handle edge cases: no unwind, different tx, missing receipt - Move owner.save() inside conditional to avoid saving unchanged state
…sitions - When liquidating a position with an associated StableLoan, update realizedPnlStables instead of realizedPnlOvl - Calculate stable PnL as: liquidateSize * stableAmount / ovlAmount
- Test liquidation scenario (no PnL modification when no unwind) - Test regular unwind with ShivaUnwind ordering check - Test different transaction (PnL not modified) - Test unordered events (PnL not modified) - Test mimic tx 0xb8837997 with correct log ordering
- Test build (0xfc566884) -> unwind (0xb8837997) flow with PnL transfer - Test build (0x59e8c4cf) -> liquidation (0x0007340e) flow - Verify realizedPnlStables is correctly updated for stable loan positions - Uses actual event handlers instead of mocked entities
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.