[Fix] project name parsing for special characters in Overleaf project URIs #284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l characters - Improve parseUri to correctly handle project names containing special characters such as []. - Fallback to query.projectName if path part is missing or empty. - Ensure decodeURIComponent is used for both path and query extraction. - This fixes issues where projects with names like "[test]" could not be opened in VS Code.
iamhyc
approved these changes
Jul 3, 2025
Member
|
Seems good, nice work! @QianrenLi Please help test it locally. if possible, please also help create a new release after this merged |
iamhyc
requested changes
Jul 6, 2025
Member
|
@LaureatePoet Please address the comments above firstly so I can continue to review. |
Contributor
Author
May I resubmit the PR? |
iamhyc
approved these changes
Jul 8, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the robustness of project name parsing in the Overleaf Workshop VS Code extension.
Main changes:
[]) could not be parsed correctly.parseUri(remoteFileSystemProvider.ts), project name is now decoded from the path if present, or falls back to theprojectNamequery parameter if missing.encodeURIComponentfor the project name (projectManagerProvider.ts).This resolves the bug where projects with names like
[test]could not be opened or used in the extension.Related Issue
#283