Fix outputBuildId extraction logic #324
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@VoodooChild99 Hi, thanks for the contribution! I think it is better to fix the problem with regex, for example, 
|
Author
|
@iamhyc Thank you for reviewing this! Yes I agree, regex is more straightforward. I've pushed a new commit for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
outputBuildIdis extracted reversely using a negative index -3. However, sometimes this can go wrong. For example, I'm usingmintedand may get something like/project/xxx/user/xxx/build/xxxx/output/_minted/xxx. In this case,outputis extracted, which is not expected.This PR extracts
outputBuildIdusing a positive index 6 to avoid the above issue.This might be related with #297, because I also got the error code 500 before applying the fix.