feat(fonts): new default way to load fonts (2 extra exports + fonts) #920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, I propose to change the recommended way to load fonts
current set up
The fonts are embeded in one css file as base64 blobs. base64 takes more space than font files and are all loaded what so ever. The extended unicode blocks are also missing but required for Polish display.
after this PR
The previous import is kept as is.
There is a new recommended way to load fonts as a style definition that define multiple
@font-facerules, each one loading an independant.woffor.woff2font file.Alternatively, one can also include the styles without the fonts.