Skip to content

Conversation

@alexGNX
Copy link
Contributor

@alexGNX alexGNX commented Nov 20, 2025

Description

The fix is about detecting changes made to an okms_secret resource outside of terraform and reconcile the states.

Fixes #1147 (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

export TF_ACC=1
export OVH_ENDPOINT=ovh-eu
export OVH_APPLICATION_KEY=...
export OVH_APPLICATION_SECRET=...
export OVH_CONSUMER_KEY=...
export OVH_OKMS=...

# data source tests
go test -timeout 30s -run ^TestAccOkmsSecretDataSource_latestAndVersions$ github.com/ovh/terraform-provider-ovh/v2/ovh
go test -timeout 60s -run ^TestAccOkmsSecretDataSource_latestAndVersions$ github.com/ovh/terraform-provider-ovh/v2/ovh

# resource tests
go test -timeout 90s -run ^TestAccOkmsSecretResource_basicLifecycle$ github.com/ovh/terraform-provider-ovh/v2/ovh
go test -timeout 5m -run TestAccOkmsSecretResource_basicLifecycle github.com/ovh/terraform-provider-ovh/v2/ovh
go test -timeout 5m -run TestAccOkmsSecretResource_casMismatch github.com/ovh/terraform-provider-ovh/v2/ovh
go test -timeout 5m -run TestAccOkmsSecretResource_pathRecreateAndMetadata github.com/ovh/terraform-provider-ovh/v2/ovh

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or issues
  • I have added acceptance tests that prove my fix is effective or that my feature works
  • New and existing acceptance tests pass locally with my changes
  • I ran successfully go mod vendor if I added or modify go.mod file

@alexGNX alexGNX requested a review from a team as a code owner November 20, 2025 10:40
@alexGNX alexGNX force-pushed the dev/agagneux/okms_secret_fix branch from ac54557 to d1f97a1 Compare November 20, 2025 10:42
@alexGNX alexGNX force-pushed the dev/agagneux/okms_secret_fix branch from d1f97a1 to f1ff375 Compare November 20, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] No data change recognition in ovh_okms_secret

1 participant