Fix user executor failures missing from JUnit/XML/JSON/HTML reports#907
Open
ivan-velasco wants to merge 19 commits intoovh:masterfrom
Open
Fix user executor failures missing from JUnit/XML/JSON/HTML reports#907ivan-velasco wants to merge 19 commits intoovh:masterfrom
ivan-velasco wants to merge 19 commits intoovh:masterfrom
Conversation
Signed-off-by: Nabil <26463615+ncharaf@users.noreply.github.com> Signed-off-by: Ivan Velasco <ivan.velasco@socotra.com>
Signed-off-by: Ivan Velasco <ivan.velasco@socotra.com>
Signed-off-by: Gabriel Augendre <gabriel.augendre@ovhcloud.com> Signed-off-by: Ivan Velasco <ivan.velasco@socotra.com>
…ry (ovh#878) Signed-off-by: Daria Fortunato <daria.kobtseva@ovhcloud.com> Signed-off-by: Ivan Velasco <ivan.velasco@socotra.com>
Signed-off-by: Daria Fortunato <daria.kobtseva@ovhcloud.com> Signed-off-by: Ivan Velasco <ivan.velasco@socotra.com>
Signed-off-by: Ivan Velasco <ivan.velasco@socotra.com>
…etrieval (ovh#867) Signed-off-by: Ivan Velasco <ivan.velasco@socotra.com>
If the JSON has escaped quotes already, the parser was double escaping them making the out invalid. This will catch already escaped quotes and skip them when encountered. Signed-off-by: Shane A. Stillwell <brisk.pen7424@ranger50.com> Signed-off-by: Ivan Velasco <ivan.velasco@socotra.com>
Signed-off-by: Ivan Velasco <ivan.velasco@socotra.com>
Signed-off-by: Ivan Velasco <ivan.velasco@socotra.com>
Signed-off-by: sonpham <quangson137@gmail.com> Signed-off-by: Ivan Velasco <ivan.velasco@socotra.com>
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@ovhcloud.com> Co-authored-by: Yvonnick Esnault <yvonnick.esnault@ovhcloud.com> Signed-off-by: Ivan Velasco <ivan.velasco@socotra.com>
Co-authored-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com> Signed-off-by: Ivan Velasco <ivan.velasco@socotra.com>
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@ovhcloud.com> Co-authored-by: Yvonnick Esnault <yvonnick.esnault@ovhcloud.com> Signed-off-by: Ivan Velasco <ivan.velasco@socotra.com>
* feat(assertions): support custom assertions Signed-off-by: GitHub <noreply@github.com> * custom to user assertion Signed-off-by: Yvonnick Esnault <yvonnick.esnault@ovhcloud.com> --------- Signed-off-by: GitHub <noreply@github.com> Signed-off-by: Yvonnick Esnault <yvonnick.esnault@ovhcloud.com> Co-authored-by: Yvonnick Esnault <yvonnick.esnault@ovhcloud.com> Signed-off-by: Ivan Velasco <ivan.velasco@socotra.com>
close ovh#883 Signed-off-by: Yvonnick Esnault <yvonnick.esnault@ovhcloud.com> Co-authored-by: Yvonnick Esnault <yvonnick.esnault@ovhcloud.com> Signed-off-by: Ivan Velasco <ivan.velasco@socotra.com>
…on for JUnit and other report outputs Signed-off-by: Ivan Velasco <ivan.velasco@socotra.com>
582148b to
a1b2be8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: User-executor inner failures were only merged into the parent step inside printTestStepResult, so paths that skipped that call left reports without real error detail.
Change: After runTestSteps in RunUserExecutor, merge all inner TestStepResults into the parent (Errors, ComputedInfo, stdout/stderr; skip whitespace-only streams). Drop the merge from printTestStepResult to avoid duplicates.
Tests: tests/user_executor_with_failure.yml plus lib executors (simple + nested failure).
example