added remove_comments_char transformation to address issue #971 #1098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zimmerle
force-pushed
the
libmodsecurity
branch
from
facd413 to
214cc15
Compare
zimmerle
modified the milestones:
v3.0.0,
v3.0.0 owasp compatible,
v3.0.0 feature complete
|
Hi @bjh7242, Thanks for the patch. I will try to have a look on it today. |
zimmerle
added a commit
to owasp-modsecurity/secrules-language-tests
that referenced
this pull request
Apr 4, 2016
zimmerle
added a commit
that referenced
this pull request
Apr 4, 2016
zimmerle
added a commit
that referenced
this pull request
Apr 4, 2016
zimmerle
added a commit
that referenced
this pull request
Apr 4, 2016
Trimming the pull request #1098
|
Hi @bjh7242, Your pull request is now merged. Thanks again for patch. Few comments: Usually, before add a functionality to version 3 we expect to have regression tests that covers its basic usage, plus a few corner cases. Those unit tests are very important, among of other things, those tests are executed by our buildbots, so we can make sure that the functionality is really working in all supported platforms. Other detail that you may want to consider is the fact that we try to not use lines bigger than 80 characters. Changes that I have made:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented remove_comments_char transformation for libmodsecurity.
Removes the following characters