Skip to content

couple fixes #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

couple fixes #1178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
547260a
Add missing 'retrun's for functions declared return value. This chan…
Jun 15, 2016
1b01ffe
Use explicit variable size for copying char.
Jun 15, 2016
3f2adc8
Enforce bison requirement to 3.0.4.
Jun 15, 2016
e4f7bb3
Use PCRE for regular expressions instead of C++ regex library.
Jun 15, 2016
92a90d3
Revert previous change in favour of internal Regex implementation.
Jun 16, 2016
d83987c
Use internal PCRE based implementation of regular expressions instead…
Jun 16, 2016
aa88fd6
Fix compilation for libpthread users.
Jun 16, 2016
c929399
Unbreak build with custom location of libyajl.so
Jun 30, 2016
f2ef96a
Merge remote-tracking branch 'upstream/libmodsecurity' into libmodsec…
Jul 4, 2016
98a12ed
Add explicit 'return true;' for Transaction::extractArguments()
Jul 4, 2016
251d1d4
Fix typo (= vs ==)
Jul 4, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/actions/allow.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,11 @@ class Allow : public Action {
static std::string allowTypeToName (AllowType a) {
if (a == NoneAllowType) {
return "None";
} else if (a = RequestAllowType) {
} else if (a == RequestAllowType) {
return "Request";
} else if (a = PhaseAllowType) {
} else if (a == PhaseAllowType) {
return "Phase";
} else if (a = FromNowOneAllowType) {
} else if (a == FromNowOneAllowType) {
return "FromNowOne";
} else {
return "Unknown";
Expand Down
4 changes: 3 additions & 1 deletion src/transaction.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,8 @@ bool Transaction::extractArguments(const std::string &orig,
free(key_c);
free(value_c);
}

return true;
}


Expand Down Expand Up @@ -1740,7 +1742,7 @@ extern "C" int msc_request_body_from_file(Transaction *transaction,

/**
* @name msc_process_response_headers
* @brief Perform the analysis on the response readers.
* @brief Perform the analysis on the response headers.
*
* This function perform the analysis on the response headers, notice however
* that the headers should be added prior to the execution of this function.
Expand Down