Skip to content

Include unanmed JSON values in unnamed ARGS #1577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Include unanmed JSON values in unnamed ARGS #1577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
18 Jul 2017 - 2.9.2
-------------------

* Include unanmed JSON values in unnamed ARGS
[Issue #1576 - Marc Stern]
* IIS build refactoring and dependencies update
[Issue #1487 - @victorhora]
* Best practice: Initialize msre_var pointers
Expand Down
3 changes: 1 addition & 2 deletions apache2/msc_json.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ int json_add_argument(modsec_rec *msr, const char *value, unsigned length)
* to reference this argument; for now we simply ignore these
*/
if (!msr->json->current_key) {
msr_log(msr, 3, "Cannot add scalar value without an associated key");
return 1;
msr->json->current_key = "";
}

arg = (msc_arg *) apr_pcalloc(msr->mp, sizeof(msc_arg));
Expand Down