Skip to content

fix: align TIME_MON variable's behavior #3306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 24, 2024
+3 −2
Merged

fix: align TIME_MON variable's behavior #3306

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db7e4cb
Align TIME_MON variable's behavior
airween Nov 22, 2024
daf550e
Fix regex for test
airween Nov 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/variables/time_mon.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ void TimeMon::evaluate(Transaction *transaction,
struct tm timeinfo;
localtime_r(&timer, &timeinfo);

transaction->m_variableTimeMin.assign(std::to_string(timeinfo.tm_mon));
transaction->m_variableTimeMin.assign(std::to_string(timeinfo.tm_mon + 1));

l->push_back(new VariableValue(&m_retName,
&transaction->m_variableTimeMin));
Expand Down
3 changes: 2 additions & 1 deletion test/test-cases/regression/variable-TIME_MON.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@
]
},
"expected":{
"debug_log":"Target value: \"([0-9]+)\" \\(Variable: TIME_MON\\)"
"http_code": 200,
"debug_log":"Target value: \"[1-9][012]?\" \\(Variable: TIME_MON\\)"
},
"rules":[
"SecRuleEngine On",
Expand Down
Loading