Skip to content

v2: Accept requests whose body length is exactly equal to SecRequestBodyNoFilesLimit #3480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hnakamur wants to merge 1 commit into
base: v2/master
Choose a base branch
from
+41 −2
Open

v2: Accept requests whose body length is exactly equal to SecRequestBodyNoFilesLimit #3480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apache2/msc_reqbody.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ apr_status_t modsecurity_request_body_store(modsec_rec *msr,
}

/* Check that we are not over the request body no files limit. */
if (msr->msc_reqbody_no_files_length >= (unsigned long) msr->txcfg->reqbody_no_files_limit) {
if (msr->msc_reqbody_no_files_length > (unsigned long) msr->txcfg->reqbody_no_files_limit) {
*error_msg = apr_psprintf(msr->mp, "Request body no files data length is larger than the "
"configured limit (%ld).", msr->txcfg->reqbody_no_files_limit);
if (msr->txcfg->debuglog_level >= 1) {
Expand Down Expand Up @@ -671,7 +671,7 @@ apr_status_t modsecurity_request_body_end(modsec_rec *msr, char **error_msg) {


/* Check that we are not over the request body no files limit. */
if (msr->msc_reqbody_no_files_length >= (unsigned long)msr->txcfg->reqbody_no_files_limit) {
if (msr->msc_reqbody_no_files_length > (unsigned long)msr->txcfg->reqbody_no_files_limit) {
*error_msg = apr_psprintf(msr->mp, "Request body no files data length is larger than the "
"configured limit (%ld).", msr->txcfg->reqbody_no_files_limit);
if (msr->txcfg->debuglog_level >= 1) {
Expand Down
39 changes: 39 additions & 0 deletions tests/regression/config/10-request-directives.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -750,3 +750,42 @@
),
},

# SecRequestBodyNoFilesLimit
{
type => "config",
comment => "SecRequestBodyNoFilesLimit - length is equal to limit",
conf => q(
SecRuleEngine On
SecRequestBodyAccess On
SecRequestBodyNoFilesLimit 16
),
match_response => {
status => qr/^200$/,
},
request => new HTTP::Request(
POST => "http://$ENV{SERVER_NAME}:$ENV{SERVER_PORT}/test.txt",
[
"Content-Type" => "application/x-www-form-urlencoded",
],
"a=0123456789ABCD",
),
},
{
type => "config",
comment => "SecRequestBodyNoFilesLimit - length is larger than limit",
conf => q(
SecRuleEngine On
SecRequestBodyAccess On
SecRequestBodyNoFilesLimit 16
),
match_response => {
status => qr/^413$/,
},
request => new HTTP::Request(
POST => "http://$ENV{SERVER_NAME}:$ENV{SERVER_PORT}/test.txt",
[
"Content-Type" => "application/x-www-form-urlencoded",
],
"a=0123456789ABCDE",
),
},
Loading