Skip to content

Change auditlog file permission from CREATEMODE to dcfg->auditlog_fileperms #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from
Closed

Change auditlog file permission from CREATEMODE to dcfg->auditlog_fileperms #852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
e53f989
nginx refactoring
Apr 28, 2014
03952c7
nginx: looking for segfaults on the regression test.
Apr 28, 2014
5d8fa16
nginx: better dealing with chunked request body
Apr 29, 2014
b405850
nginx: copies the req body chain to be processed instead of move
Apr 29, 2014
8a722e8
nginx: cosmetics: Splits lines longer than 80 characters
Apr 30, 2014
97a8239
nginx: cosmetics: Removes trailing whitespace
Apr 30, 2014
d2a1b61
niginx: cosmetics: Changes CRLF to LF
Apr 30, 2014
a841260
Bugfix: add -P option in test script
InfoHunter May 14, 2014
4846528
Removed unneeded and invalid initialization.
defanator May 14, 2014
c7ed4dd
Obtain port from r->connection->local_sockaddr.
defanator May 15, 2014
1d71116
nginx: fixing fuzzyHash test case for nginx
Jan 9, 2015
dd61b18
Passthrough the saved Response headers in the response
rmongia Jun 30, 2014
dc2461d
Allow non-zero Content-Length for HEAD requests
Aug 8, 2014
1f1eea3
Fix missing status_line when logging in nginx.
Feb 25, 2015
226ad1d
Avoids segfault while running with proxy_pass
Mar 21, 2015
51200fc
Update apache2_config.c
littlecho Mar 26, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions apache2/apache2_config.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1189,10 +1189,13 @@ static const char *cmd_audit_log(cmd_parms *cmd, void *_dcfg, const char *p1)
else {
const char *file_name = ap_server_root_relative(cmd->pool, dcfg->auditlog_name);
apr_status_t rc;


if (dcfg->auditlog_fileperms == NOT_SET) {
dcfg->auditlog_fileperms = CREATEMODE;
}
rc = apr_file_open(&dcfg->auditlog_fd, file_name,
APR_WRITE | APR_APPEND | APR_CREATE | APR_BINARY,
CREATEMODE, cmd->pool);
dcfg->auditlog_fileperms, cmd->pool);

if (rc != APR_SUCCESS) {
return apr_psprintf(cmd->pool, "ModSecurity: Failed to open the audit log file: %s",
Expand Down
2 changes: 1 addition & 1 deletion apache2/mod_security2.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1278,7 +1278,7 @@ static int hook_log_transaction(request_rec *r) {

msr->r = r;
msr->response_status = r->status;
msr->status_line = ((r->status_line != NULL)
msr->status_line = ((r->status_line != NULL) && (*r->status_line != '\0')
? r->status_line : ap_get_status_line(r->status));
msr->response_protocol = get_response_protocol(origr);
msr->response_headers = apr_table_copy(msr->mp, r->headers_out);
Expand Down
Loading