Added support to specify a different implementation of the queue listener #1032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willpower232
reviewed
Sep 2, 2025
Co-authored-by: Will Power <[email protected]>
erikn69
reviewed
Sep 2, 2025
|
|
||
| Event::listen(AuditCustom::class, RecordCustomAudit::class); | ||
| Event::listen(DispatchAudit::class, ProcessDispatchAudit::class); | ||
| Event::listen(DispatchAudit::class, Config::string('audit.queue.listener', ProcessDispatchAudit::class)); |
There was a problem hiding this comment.
@willpower232 hi, maybe an interface check, to prevent someone from setting up a class that is not a listener, or some non-existent class
There was a problem hiding this comment.
If we are going to have settable listeners, shouldn't RecordCustomAudit listener have the same option?
There was a problem hiding this comment.
@markieo1 what do you think about adding an option for the custom audit and then using class_exists and probably method_exists for handle? not sure there is an interface for event listeners
There was a problem hiding this comment.
It is a good option, another could be to create a new contract that requires having a handle method and validate that interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
As discussed in #1031, hereby the PR.
The code defaults to the
ProcessDispatchAudit. When a different implementation is provided ornull, Laravel uses this. Laravel already handles thenullcorrectly.Using it this way anyone can provide a custom listener implementation.