Skip to content

Laravel 13.x Compatibility#1044

Open
laravel-shift wants to merge 2 commits intoowen-it:masterfrom
laravel-shift:l13-compatibility
Open

Laravel 13.x Compatibility#1044
laravel-shift wants to merge 2 commits intoowen-it:masterfrom
laravel-shift:l13-compatibility

Conversation

@laravel-shift
Copy link
Contributor

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 13.x.

Before merging, you need to:

  • Checkout the l13-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

@laravel-shift
Copy link
Contributor Author

⚠️ The latest version of Laravel has a dependency for phpunit/phpunit of ^12.5. If you would like to also upgrade your tests, you may run the PHPUnit 12 Shift for free.

@laravel-shift
Copy link
Contributor Author

⚠️ Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 13. However, you should review these changes to ensure the desired combination of versions are built for your package.

@laravel-shift
Copy link
Contributor Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/laravel-auditing.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "owen-it/laravel-auditing": "dev-l13-compatibility",
    }
}

Finally, run: composer update

@willpower232
Copy link
Contributor

This looks fine, I expect the unrelated changes to run-tests.yaml have meant that tests didn't run here so will probably have to tinker with them at some point.

Obviously orchestra/testbench hasn't released version 11 yet so probably have to wait for that before this will work properly in CI.

Past me dealt with the phpunit deprecations already in #1006 so there shouldn't be an issue running both phpunit versions for now.

@jasonmccreary
Copy link

@willpower232, I think the * must be quoted. I patched this in a recent run, but the PR for this must have been in the first run. That may resolve the "tests not running".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants