📊 Refactor chart-preview extension: unify chart and dataset preview#5717
Merged
📊 Refactor chart-preview extension: unify chart and dataset preview#5717
Conversation
Introduce a PreviewStrategy interface to eliminate duplicated code between
chart preview and dataset preview. Both now share a single openPreview()
and startWatchProcess() flow, with strategy objects providing the
type-specific behavior (completion detection, reload HTML, etc.).
Key simplifications:
- Replace complex stepsRunning/detectingDirty/pendingReloadTimer state
machine with the universal "--- Dataset rebuild complete" sentinel
- Remove auto-restart on crash (Retry button handles this now)
- Add Retry button to all chart preview error screens (was dataset-only)
- Consistent error titles ("Preview Error" for both paths)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Quick links (staging server):
Login: chart-diff: ✅No charts for review.data-diff: ✅ No differences foundAutomatically updated datasets matching excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included Edited: 2026-02-26 09:27:00 UTC |
Collaborator
Author
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8541cf36bd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor and enhance the chart-preview VSCode extension:
chartStrategy/datasetStrategy) replaces separate code paths for chart and dataset previews--instant(metadata-only), Python changes trigger full rebuild — no more manual--instantflag.meta.ymlsupport: Opening a.meta.ymlfile triggers the dataset preview for its parent stepdescription_keydisplay (was showing[object Object]), hide emptyunitfields.vscodeignoreto excludeout/,src/, build config from.vsix🤖 Generated with Claude Code