🔨 (etl) replace hideLegend with hideSeriesLabels#5719
Merged
sophiamersmann merged 1 commit intomasterfrom Mar 4, 2026
Merged
Conversation
Contributor
|
Quick links (staging server):
Login: chart-diff: ✅No charts for review.data-diff: ❌ Found differences= Dataset garden/growth/2024-05-16/gdp_historical
= Table gdp_historical
~ Column gdp (changed metadata)
- - hideLegend: true
+ + hideSeriesLabels: true
~ Column gdp_per_capita (changed metadata)
- - hideLegend: true
+ + hideSeriesLabels: true
= Dataset garden/worldbank_wdi/2026-01-29/wdi
= Table wdi
~ Column ne_trd_gnfs_zs (changed metadata)
- - presentation:
- - topic_tags:
- - - Trade & Globalization
~ Column sl_emp_totl_sp_fe_ne_zs (changed metadata)
- - This indicator is defined as the proportion of a country’s working-age population that is employed. It is also known as the employment-to-population ratio. Employment refers to people who worked for at least an hour during the reference period (typically a week), whether in paid employment or self-employment. This indicator gives a broad sense of how many people in a country are working, regardless of the kind of job they have or how many hours they work.
+ + This indicator is defined as the proportion of a country’s working-age population that is employed. Employment refers to people who worked for at least an hour during the reference period (typically a week), whether in paid employment or self-employment. This indicator gives a broad sense of how many people in a country are working, regardless of the kind of job they have or how many hours they work.
- - name: Female employment rate
+ + name: Female employment-to-population ratio
- - title: Female employment rate
+ + title: Female employment-to-population ratio
~ Column sl_emp_totl_sp_fe_zs (changed metadata)
- - This indicator is defined as the proportion of a country’s working-age population that is employed. It is also known as the employment-to-population ratio. Employment refers to people who worked for at least an hour during the reference period (typically a week), whether in paid employment or self-employment. This indicator gives a broad sense of how many people in a country are working, regardless of the kind of job they have or how many hours they work.
+ + This indicator is defined as the proportion of a country’s working-age population that is employed. Employment refers to people who worked for at least an hour during the reference period (typically a week), whether in paid employment or self-employment. This indicator gives a broad sense of how many people in a country are working, regardless of the kind of job they have or how many hours they work.
- - name: Female employment rate
+ + name: Female employment-to-population ratio
- - title: Female employment rate
+ + title: Female employment-to-population ratio
~ Column sl_emp_totl_sp_ma_zs (changed metadata)
- - This indicator is defined as the proportion of a country’s working-age population that is employed. It is also known as the employment-to-population ratio. Employment refers to people who worked for at least an hour during the reference period (typically a week), whether in paid employment or self-employment. This indicator gives a broad sense of how many people in a country are working, regardless of the kind of job they have or how many hours they work.
+ + This indicator is defined as the proportion of a country’s working-age population that is employed. Employment refers to people who worked for at least an hour during the reference period (typically a week), whether in paid employment or self-employment. This indicator gives a broad sense of how many people in a country are working, regardless of the kind of job they have or how many hours they work.
- - name: Male employment rate
+ + name: Male employment-to-population ratio
- - title: Male employment rate
+ + title: Male employment-to-population ratio
~ Column sl_emp_totl_sp_ne_zs (changed metadata)
- - This indicator is defined as the proportion of a country’s working-age population that is employed. It is also known as the employment-to-population ratio. Employment refers to people who worked for at least an hour during the reference period (typically a week), whether in paid employment or self-employment. This indicator gives a broad sense of how many people in a country are working, regardless of the kind of job they have or how many hours they work.
+ + This indicator is defined as the proportion of a country’s working-age population that is employed. Employment refers to people who worked for at least an hour during the reference period (typically a week), whether in paid employment or self-employment. This indicator gives a broad sense of how many people in a country are working, regardless of the kind of job they have or how many hours they work.
- - name: Employment rate
+ + name: Employment-to-population ratio
- - title: Employment rate
+ + title: Employment-to-population ratio
~ Column sl_emp_totl_sp_zs (changed metadata)
- - This indicator is defined as the proportion of a country’s working-age population that is employed. It is also known as the employment-to-population ratio. Employment refers to people who worked for at least an hour during the reference period (typically a week), whether in paid employment or self-employment. This indicator gives a broad sense of how many people in a country are working, regardless of the kind of job they have or how many hours they work.
+ + This indicator is defined as the proportion of a country’s working-age population that is employed. Employment refers to people who worked for at least an hour during the reference period (typically a week), whether in paid employment or self-employment. This indicator gives a broad sense of how many people in a country are working, regardless of the kind of job they have or how many hours they work.
- - name: Employment rate
+ + name: Employment-to-population ratio
- - title: Employment rate
+ + title: Employment-to-population ratio
Legend: +New ~Modified -Removed =Identical Details
Hint: Run this locally with etl diff REMOTE data/ --include yourdataset --verbose --snippetAutomatically updated datasets matching excess_mortality|covid|fluid|flunet|country_profile|garden/ihme_gbd/2019/gbd_risk are not included Edited: 2026-02-26 10:10:24 UTC |
sophiamersmann
commented
Feb 26, 2026
Comment on lines
-293
to
-295
| "hideLegend": { | ||
| "$ref": "https://files.ourworldindata.org/schemas/grapher-schema.009.json#/properties/hideLegend" | ||
| }, |
Member
Author
There was a problem hiding this comment.
Dropped without replacement because explorers never supported the hideLegend field (and I also didn't add support for the new hideSeriesLabels field).
322cc36 to
efbc75f
Compare
5 tasks
efbc75f to
f6f4b2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Wait for PRs in owid-grapher to land before merging
Renames the chart config's
hideLegendtohideSeriesLabels. Because this is a breaking change, the config schema version is bumped from 009 to 010.For line charts, slope charts and stacked area charts,
hideLegendis renamed tohideSeriesLabels. For all other chart types,hideLegendis dropped.As far as I can see, all charts here that currently use the
hideLegendare line charts, so I renamed them tohideSeriesLabelsThe ETL unit tests are failing because there's no config schema yet at https://files.ourworldindata.org/schemas/grapher-schema.010.json. I guess, I'll wait for the owid-grapher PR to land, then run the test suite again?
I don't understand some of the differences reported by data-diff - seem to be unrelated.