refactor: use view binding instead of inflate and findViewById for space bottom sheet dialog

Author: joragua

owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/SpacesListFragment.kt

@@ -29,8 +29,6 @@ import android.view.Menu
 import android.view.MenuInflater
 import android.view.View
 import android.view.ViewGroup
-import android.widget.ImageView
-import android.widget.TextView
 import androidx.appcompat.widget.SearchView
 import androidx.core.os.bundleOf
 import androidx.core.view.isVisible
@@ -40,6 +38,7 @@ import androidx.recyclerview.widget.GridLayoutManager
 import com.google.android.material.bottomsheet.BottomSheetBehavior
 import com.google.android.material.bottomsheet.BottomSheetDialog
 import com.owncloud.android.R
+import com.owncloud.android.databinding.FileOptionsBottomSheetFragmentBinding
 import com.owncloud.android.databinding.SpacesListFragmentBinding
 import com.owncloud.android.domain.files.model.FileListOption
 import com.owncloud.android.domain.spaces.model.OCSpace
@@ -171,27 +170,27 @@ class SpacesListFragment : SpacesListAdapter.SpacesListAdapterListener, Fragment
     }
 
     override fun onThreeDotButtonClick(ocSpace: OCSpace) {
-        val spaceOptionsBottomSheet = layoutInflater.inflate(R.layout.file_options_bottom_sheet_fragment, null)
+        val spaceOptionsBottomSheetBinding = FileOptionsBottomSheetFragmentBinding.inflate(layoutInflater)
         val dialog = BottomSheetDialog(requireContext())
-        dialog.setContentView(spaceOptionsBottomSheet)
+        dialog.setContentView(spaceOptionsBottomSheetBinding.root)
 
-        val fileOptionsBottomSheetSingleFileBehavior: BottomSheetBehavior<*> = BottomSheetBehavior.from(spaceOptionsBottomSheet.parent as View)
-        val closeBottomSheetButton = spaceOptionsBottomSheet.findViewById<ImageView>(R.id.close_bottom_sheet)
+        val fileOptionsBottomSheetSingleFileBehavior: BottomSheetBehavior<*> = BottomSheetBehavior.from(
+            spaceOptionsBottomSheetBinding.root.parent as View)
+        val closeBottomSheetButton = spaceOptionsBottomSheetBinding.closeBottomSheet
         closeBottomSheetButton.setOnClickListener {
-            dialog.hide()
             dialog.dismiss()
         }
 
-        val thumbnailBottomSheet = spaceOptionsBottomSheet.findViewById<ImageView>(R.id.thumbnail_bottom_sheet)
+        val thumbnailBottomSheet = spaceOptionsBottomSheetBinding.thumbnailBottomSheet
         thumbnailBottomSheet.setImageResource(R.drawable.ic_menu_space)
 
-        val spaceNameBottomSheet = spaceOptionsBottomSheet.findViewById<TextView>(R.id.file_name_bottom_sheet)
+        val spaceNameBottomSheet = spaceOptionsBottomSheetBinding.fileNameBottomSheet
         spaceNameBottomSheet.text = ocSpace.name
 
-        val spaceSizeBottomSheet = spaceOptionsBottomSheet.findViewById<TextView>(R.id.file_size_bottom_sheet)
+        val spaceSizeBottomSheet = spaceOptionsBottomSheetBinding.fileSizeBottomSheet
         spaceSizeBottomSheet.text = DisplayUtils.bytesToHumanReadable(ocSpace.quota?.used ?: 0L, requireContext(), true)
 
-        val spaceSeparatorBottomSheet = spaceOptionsBottomSheet.findViewById<TextView>(R.id.file_separator_bottom_sheet)
+        val spaceSeparatorBottomSheet = spaceOptionsBottomSheetBinding.fileSeparatorBottomSheet
         spaceSeparatorBottomSheet.visibility = View.GONE
 
         fileOptionsBottomSheetSingleFileBehavior.addBottomSheetCallback(object : BottomSheetBehavior.BottomSheetCallback() {
@@ -203,7 +202,7 @@ class SpacesListFragment : SpacesListAdapter.SpacesListAdapterListener, Fragment
             override fun onSlide(bottomSheet: View, slideOffset: Float) {}
         })
 
-        dialog.setOnShowListener { fileOptionsBottomSheetSingleFileBehavior.peekHeight = spaceOptionsBottomSheet.measuredHeight }
+        dialog.setOnShowListener { fileOptionsBottomSheetSingleFileBehavior.peekHeight = spaceOptionsBottomSheetBinding.root.measuredHeight }
         dialog.show()
     }