-
Notifications
You must be signed in to change notification settings - Fork 3.1k
[FIX] Incorrect folder size after a move operation #4553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Incorrect folder size after a move operation #4553
Conversation
97c39b3 to
7b85a52
Compare
|
Thanks for your contribution!! team will review it and come back to you with feedback about the code quality and functional review. Stay tuned to the code review and QA-phase! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @CodeObsessed-1234!🏅One thing about commits: we don't usually link the issue to the commit message because in the pull request we have that reference. Also, I left some comments for you to review them:
69f2c2c to
2486551
Compare
|
I've addressed all the requested changes. Please review again when you get a chance. Thanks! |
joragua
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More changes here @CodeObsessed-1234!
2486551 to
13df17a
Compare
joragua
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @CodeObsessed-1234! It's ready for QA! Let's move it 🚀
|
My QA feedback: The solution works, since the displayed folder size is the correct one. The fix, changing the folder size is a bit blinky, but i don't consider that as blocker since the problem is edge-case. The most-desired solution would be not to update the list till the user's final decision is made, avoiding the refresh and the blink in the size. But, at least, the current fixes the glitch. Let's go for it and feel free to think in a better approach ;) Approved. |
|
@jesmrec Thanks for the feedback! I understand the concern about the blinky effect. This fix resolves the glitch for now, but I’ll keep the suggested improvement in mind for future refinements. 😊.. |
|
Hi, |
no action required from your side, BiRise is pending for an internal fix, as soon as it is fixed your contribution will be in. Thanks!! |
|
Hi @CodeObsessed-1234! Would you be able to rebase this branch against the |
|
Hi @JuancaG05 To re-trigger the PR checks, I added an empty commit and pushed it. |
|
Hi @CodeObsessed-1234! Can you remove the two empty commits that you pushed with an interactive rebase? The problem with bitrise is still happening so, we will fix it as soon as possible. If you don't know how to do it, let us know and we will help you 😄 |
|
@CodeObsessed-1234 hey, let's wait until we tell you the final settings are configured and then you can remove those empty commits, to finally merge it 😬 sorry for the inconveniences and thanks for the patience! |
|
Here we go! CI/CD it's ready! @CodeObsessed-1234, now you can rebase this branch against |
9308f30 to
13df17a
Compare
13df17a to
1ddf20f
Compare
Description
This PR fixes an issue where the folder size was not updating correctly after replacing a file with the same name. Previously, the folder size showed duplicate files until a manual refresh was performed.
Fix Details
fileOperationsViewModel.performOperation(FileOperation.RefreshFolderOperation(...)).spacesListViewModel.refreshSpacesFromServer().Related Issues
Fixes #<4505>
How to Test
Checklist
changelog/unreleased/preview.mp4