[FIX] Confusing behaviour when creating new files using apps provider

[joragua]

Related Issues

App: #4560

• Add changelog files for the fixed issues in folder changelog/unreleased. More info here
• Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

---

QA

Checks: #4562 (comment)

Reports

• (1) Migration [FIX] Confusing behaviour when creating new files using apps provider #4562 (comment) [FIXED]

[JuancaG05]

A little change in the release note 👍

[JuancaG05]

LGTM now

[jesmrec]

[WIP]

QA checks:

• Create new file

  • OpenPresentation
  • OpenSpreadsheet
  • OpenDocument
  • Microsoft PowerPoint
  • Microsoft Excel
  • Microsoft Word

• Open file

  • .odp
  • .ods
  • .odt
  • .pptx
  • .xlsx
  • .docx

• Update

[jesmrec]

(1) [FIXED]

Migration from previous version makes the app crash.

1. Install master
2. Add an account with app providers
3. Update to current branch

Current:

app crashes at start:

13:51:49.486  E  Process: com.owncloud.android.debug, PID: 14262 (Ask Gemini)
                 com.squareup.moshi.JsonDataException: Required value 'productName' missing at $[1]
                 	at com.squareup.moshi.internal.Util.missingProperty(Util.java:660)
                 	at com.squareup.moshi.kotlin.reflect.KotlinJsonAdapter.fromJson(KotlinJsonAdapter.kt:105)
                 	at com.squareup.moshi.internal.NullSafeJsonAdapter.fromJson(NullSafeJsonAdapter.java:41)
                 	at com.squareup.moshi.CollectionJsonAdapter.fromJson(CollectionJsonAdapter.java:81)
                 	at com.squareup.moshi.CollectionJsonAdapter$2.fromJson(CollectionJsonAdapter.java:55)
                 	at com.squareup.moshi.internal.NullSafeJsonAdapter.fromJson(NullSafeJsonAdapter.java:41)
                 	at com.squareup.moshi.JsonAdapter.fromJson(JsonAdapter.java:70)
                 	at com.owncloud.android.data.appregistry.datasources.implementation.OCLocalAppRegistryDataSource.toAppRegistryProvider(OCLocalAppRegistryDataSource.kt:107)
                 	at com.owncloud.android.data.appregistry.datasources.implementation.OCLocalAppRegistryDataSource.toModel(OCLocalAppRegistryDataSource.kt:84)
                 	at com.owncloud.android.data.appregistry.datasources.implementation.OCLocalAppRegistryDataSource.access$toModel(OCLocalAppRegistryDataSource.kt:38)
                 	at com.owncloud.android.data.appregistry.datasources.implementation.OCLocalAppRegistryDataSource$getAppRegistryWhichAllowCreation$$inlined$map$1$2.emit(Emitters.kt:224)
                 	at kotlinx.coroutines.flow.internal.SafeCollectorKt$emitFun$1.invoke(SafeCollector.kt:15)
                 	at kotlinx.coroutines.flow.internal.SafeCollectorKt$emitFun$1.invoke(SafeCollector.kt:15)
                 	at kotlinx.coroutines.flow.internal.SafeCollector.emit(SafeCollector.kt:87)
                 	at kotlinx.coroutines.flow.internal.SafeCollector.emit(SafeCollector.kt:66)
                 	at kotlinx.coroutines.flow.FlowKt__ChannelsKt.emitAllImpl$FlowKt__ChannelsKt(Channels.kt:62)
                 	at kotlinx.coroutines.flow.FlowKt__ChannelsKt.access$emitAllImpl$FlowKt__ChannelsKt(Channels.kt:1)
                 	at kotlinx.coroutines.flow.FlowKt__ChannelsKt$emitAllImpl$1.invokeSuspend(Unknown Source:14)
                 	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
                 	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
                 	at android.os.Handler.handleCallback(Handler.java:959)
                 	at android.os.Handler.dispatchMessage(Handler.java:100)
                 	at android.os.Looper.loopOnce(Looper.java:249)
                 	at android.os.Looper.loop(Looper.java:337)
                 	at android.app.ActivityThread.main(ActivityThread.java:9593)
                 	at java.lang.reflect.Method.invoke(Native Method)
                 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:593)
                 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
                 	Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [StandaloneCoroutine{Cancelling}@c77c809, Dispatchers.Main.immediate]
13:51:49.487  E  MiSurfaceFlingerImpl.cpp.vsyncId=507446, oldVsyncId=507426, layerName=Surface(name=5da4fb Splash Screen com.owncloud.android.debug#2597)/@0xdf5fce2 - animation-leash of window_animation#2611

Expected:

no crash

Xiaomi Redmi 13 Android 15
bce15bde8

[joragua]

@jesmrec (1) should be fixed with the last commit

[jesmrec]

(1) fixed

[jesmrec]

Approved on my side.

In regression stage will do another check.