[FIX] App crashes at start when biometrics fail #4564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joragua
changed the title
joragua
changed the title
joragua
force-pushed
the
fix/biometrics_crash_at_start
branch
from
a78807b to
4bce200
Compare
JuancaG05
requested changes
Mar 31, 2025
...dApp/src/main/java/com/owncloud/android/presentation/security/biometric/BiometricActivity.kt
Outdated
Show resolved
Hide resolved
...loudApp/src/main/java/com/owncloud/android/presentation/security/passcode/PassCodeManager.kt
Outdated
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/presentation/security/pattern/PatternManager.kt
Outdated
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/presentation/security/pattern/PatternManager.kt
Outdated
Show resolved
Hide resolved
joragua
force-pushed
the
fix/biometrics_crash_at_start
branch
from
5e09f8a to
6199d53
Compare
JuancaG05
requested changes
Apr 1, 2025
...udApp/src/main/java/com/owncloud/android/presentation/security/biometric/BiometricManager.kt
Outdated
Show resolved
Hide resolved
...loudApp/src/main/java/com/owncloud/android/presentation/security/passcode/PassCodeManager.kt
Outdated
Show resolved
Hide resolved
…ricCancelled function
joragua
force-pushed
the
fix/biometrics_crash_at_start
branch
from
c53dd50 to
934a9a0
Compare
Collaborator
Author
QA TestsTest 1: ✅ Initially, no faceid/fingerprint enrolled in device
Test 2: ✅
|
Collaborator
|
Thanks for testing @joragua!! Let's move this forward |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
App: https://github.com/owncloud/enterprise/issues/7134
ReleaseNotesViewModel.ktcreating a newReleaseNote()with String resources (if required)QA