[FIX] Lack of margin when multiaccount is disabled #4567
Conversation
JuancaG05
changed the title
JuancaG05
left a comment
JuancaG05
left a comment
There was a problem hiding this comment.
Hey @goonerDroid! Nice first PR! 🚀
Just a couple of things in the Calens file to fix 👍. Also, the commit for the calens file should be chore: added calens file or whatever, but with the chore prefix if possible 😀.
|
@JuancaG05 Have added the changes you've requested, let me know if it requires any more changes |
JuancaG05
left a comment
JuancaG05
left a comment
There was a problem hiding this comment.
Hi @goonerDroid! We're good to go, just a detail to polish (for this and future PR): we like keeping the commit history clean, so we usually just add one commit for calens stuff. Could you remove the second commit of this PR and just keep the last one for calens purposes? 😸
goonerDroid
force-pushed
the
fix/lack_of_margin_when_multiaccount_is_disabled
branch
from
165b6e8 to
c0edc9b
Compare
|
@JuancaG05 rebased commit history. Would keep in mind for future PR's😀 |
JuancaG05
left a comment
JuancaG05
left a comment
There was a problem hiding this comment.
Cool! 🥇 LGTM, let's move it to QA!
|
Checked both cases, with and without multiaccount. Now, it looks much better. Approved on my side. Thanks @goonerDroid for your contribution!!! 💯 |
3 participants
Related Issues
App: #4566
QA
Before fix
After fix