Skip to content

[FEATURE REQUEST] Shares space in Android native file explorer#4579

Merged
joragua merged 5 commits intomasterfrom
feature/shares_space_docs_provider
Apr 29, 2025
Merged

[FEATURE REQUEST] Shares space in Android native file explorer#4579
joragua merged 5 commits intomasterfrom
feature/shares_space_docs_provider

Conversation

@JuancaG05
Copy link
Copy Markdown
Contributor

@JuancaG05 JuancaG05 commented Apr 22, 2025

Related Issues

App: #4515

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

QA checks: #4579 (comment)

@JuancaG05 JuancaG05 self-assigned this Apr 22, 2025
@JuancaG05 JuancaG05 linked an issue Apr 22, 2025 that may be closed by this pull request
@JuancaG05 JuancaG05 requested a review from joragua April 22, 2025 12:31
@JuancaG05 JuancaG05 force-pushed the feature/shares_space_docs_provider branch from bc84419 to ee7858d Compare April 22, 2025 12:35
Copy link
Copy Markdown
Collaborator

@joragua joragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @JuancaG05! 😄 One tiny comment about the release note and it's done:

@JuancaG05 JuancaG05 requested a review from joragua April 24, 2025 06:37
Copy link
Copy Markdown
Collaborator

@joragua joragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!

@jesmrec
Copy link
Copy Markdown
Collaborator

jesmrec commented Apr 28, 2025

QA checks:

  • No shares
  • Shared file
  • Shared folder
  • Shared files and folders
  • oC10

@jesmrec
Copy link
Copy Markdown
Collaborator

jesmrec commented Apr 28, 2025

(1)

Items in the Share space have limited operation-set in the Android app. Just listing and previewing (downloading)

They shouldn't be...

  • removed
  • renamed
  • moved to other location
  • able to add or remove items inside, in case of folders
  • update the content, in case of flies

all of these operations are still available in the documents provider for items inside the Share space.

Xiaomi Redmi 13, Android 15
5f995e9e

@joragua joragua force-pushed the feature/shares_space_docs_provider branch from 57251b9 to fef53fc Compare April 29, 2025 12:44
@joragua
Copy link
Copy Markdown
Collaborator

joragua commented Apr 29, 2025

(1) should be fixed now! 😄 @jesmrec

@jesmrec
Copy link
Copy Markdown
Collaborator

jesmrec commented Apr 29, 2025

(1) is fixed

@jesmrec
Copy link
Copy Markdown
Collaborator

jesmrec commented Apr 29, 2025

Approved!!

@joragua joragua force-pushed the feature/shares_space_docs_provider branch from fef53fc to 587edb0 Compare April 29, 2025 15:36
@joragua joragua merged commit ce75dc2 into master Apr 29, 2025
8 checks passed
@joragua joragua deleted the feature/shares_space_docs_provider branch April 29, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Shares space in Android native file explorer

4 participants