[FIX] No message when uploading a file with no quota

[joragua]

Related Issues

App: #4582

• Add changelog files for the fixed issues in folder changelog/unreleased. More info here
• Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

---

QA

QA checks:

Reports:

• (1) (improvement) Snackbar during many uploads [FIX] No message when uploading a file with no quota #4587 (comment) [wont fix]

[jesmrec]

A couple of comments/questions there, @joragua

[jesmrec]

moved to (myself) QA

[jesmrec]

QA checks:

• Upload shortcut with no quota -> snackbar displayed
• Upload file with no quota -> snackbar displayed
• Upload many files with no quota -> snackbar displayed
• Upload many files with quota for some of them -> snackbar displayed
• Upload photo from camera with no quota -> snackbar displayed

Some regression...

• Upload shortcut with quota -> snackbar not displayed, shortcut uploaded
• Upload file with quota -> snackbar not displayed, file uploaded
• Upload many files with quota -> snackbar not displayed, files uploaded
• Upload photo from camera with quota -> snackbar not displayed, photo uploaded

[jesmrec]

(1)

I noticed the following behaviour, i am not sure it can be handled but just in case....

1. Set an account with a quota that is close to the limit
2. Upload 100 files (or a number of files for which there is not quota enough)

Files start to upload, some of them are uploaded till the quota is exceeded. Then, uploads fail because no storage. This is totally correct ✅

But, there is no snackbar in this case, i guess because quota was not 0 when the operation started but "in the middle".

My guess is, the only way to add the snackbar afterwards is checking the quota in every individual upload, right? would this be worthy just for only showing an snackbar?

Not a blocker in any case... just something to improve

[joragua]

Right now, the quota is not updated after every individual upload (it is only updated when all files have finished with a successful/failed result). In any case, (1) is a good improvement but it implies more changes in the code... 😄

[jesmrec]

Right now, the quota is not updated after every individual upload (it is only updated when all files have finished with a successful/failed result). In any case, (1) is a good improvement but it implies more changes in the code... 😄

got it! for the moment the new approach is more than enough... now users will have line feedback in case of lack of storage.

From my side it's approved.