Skip to content

Conversation

@jesmrec
Copy link
Collaborator

@jesmrec jesmrec commented Jul 2, 2025

Changes:

  • Replaced the read permission for write, since we have to push

  • sbom.json to be created when pushing to master. Before: in every PR, does not matter the target branch.

  • sbom.json file in root folder of the current repository

  • Added a step that will compare the sbom.json in master with the generated one. If they match, no push (no changes since the latest time).

Related Issues

App:

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@jesmrec jesmrec changed the title feat: modify sbom workflow to push to the repo instead of creating ac… [FEATURE REQUEST] Modify sbom workflow to push to the repo Jul 2, 2025
@jesmrec jesmrec force-pushed the fix/sbom_into_repository branch 25 times, most recently from 2524663 to db63655 Compare July 4, 2025 08:15
@jesmrec jesmrec marked this pull request as ready for review July 4, 2025 08:35
@jesmrec jesmrec force-pushed the fix/sbom_into_repository branch from db63655 to f96ccc5 Compare July 4, 2025 08:36
@jesmrec jesmrec force-pushed the fix/sbom_into_repository branch from f96ccc5 to 2a93706 Compare July 4, 2025 10:58
@jesmrec jesmrec requested a review from Copilot July 4, 2025 11:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the SBOM workflow to generate and push an sbom.json file only on pushes to the default branches, comparing it against the current master to avoid redundant commits.

  • Switched from pull_request to push triggers on master and main, and updated permissions to write.
  • Generates, cleans, and compares the SBOM JSON against the default branch, committing only if changes are detected.
  • Moves the SBOM into the repo root and streamlines the workflow steps.
Comments suppressed due to low confidence (2)

.github/workflows/sbom.yml:20

  • The comment states you need the full repository history, but the checkout step lacks fetch-depth: 0. Add fetch-depth: 0 under with: to ensure all commits are fetched for diff operations.
        uses: actions/checkout@v4

.github/workflows/sbom.yml:59

  • This always fetches origin/master even when running on main. To handle both branches, dynamically fetch the current branch (e.g., using ${GITHUB_REF##*/}) or fetch both origin/master and origin/main before comparison.
        run: git fetch origin master

@jesmrec jesmrec requested review from DeepDiver1975 and joragua July 4, 2025 11:34
Copy link
Collaborator

@joragua joragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments here @jesmrec!

@jesmrec jesmrec force-pushed the fix/sbom_into_repository branch from 46d4613 to 18cb7f2 Compare July 4, 2025 12:59
@jesmrec jesmrec requested a review from joragua July 4, 2025 13:00
Copy link
Collaborator

@joragua joragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯 Let's see if it works in master branch

@jesmrec jesmrec merged commit c1d5483 into master Jul 4, 2025
9 checks passed
@jesmrec jesmrec deleted the fix/sbom_into_repository branch July 4, 2025 13:07
@joragua joragua removed the Sprint label Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants