[FEATURE REQUEST] Add account information to the user#4647
[FEATURE REQUEST] Add account information to the user#4647
Conversation
joragua
force-pushed
the
feature/add_account_id_to_the_user
branch
2 times, most recently
from
93659ba to
6ff4c9d
Compare
joragua
force-pushed
the
feature/add_account_id_to_the_user
branch
2 times, most recently
from
fd03a50 to
447dfc0
Compare
joragua
force-pushed
the
feature/add_account_id_to_the_user
branch
from
064495d to
1aabf85
Compare
changelog/unreleased/4647
Outdated
| @@ -0,0 +1,7 @@ | |||
| Enhancement: Add account ID information to the user | |||
There was a problem hiding this comment.
My option here: Add account ID to the user information . User is confusing... it's the one that uses the app :D
There was a problem hiding this comment.
I agree. Changed! 👍🏻
|
|
||
| Timber.d("Get user id completed and parsed to ${result.data}") | ||
| } else { | ||
| result = RemoteOperationResult(getMethod) |
There was a problem hiding this comment.
why getMethod as parameter here? shouldn't be any error information like ResultCode.xxx?
There was a problem hiding this comment.
The constructor used here takes a HttpMethod as its parameter. It is intended for cases when the result needs to be interpreted from the response (You can see the implementation in the RemoteOperationResult class)
There was a problem hiding this comment.
👍 . RemoteOperationResult has a bunch of creators calling themselves... that confused me. That's OK
joragua
force-pushed
the
feature/add_account_id_to_the_user
branch
from
5453ec9 to
3ac5ccc
Compare
|
CR approved |
|
@joragua, the process of adding the client ID works fine for new accounts. But, i guess that it won't work for migrations, since the id is saved in first instance. |
3 participants
Related Issues
App: #4605
ReleaseNotesViewModel.ktcreating a newReleaseNote()with String resources (if required)QA