[FIX] Removed files in failed uploads

[joragua]

Related Issues

App: #4653

• Add changelog files for the fixed issues in folder changelog/unreleased. More info here
• Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

---

QA

[jesmrec]

LGTM 👍

[jesmrec]

Filling up the use cases chart:

Uploads

Manual retry

Server down, credentials revoked

Scenario	Outcome	Local source	/tmp	oC10	oCIS	Comment
Manual	1st att ✅	Keep file	clean	✅	✅
Manual	1st att ❌	Keep file	file	✅	✅
Manual	2nd att ✅	Keep file	clean	✅	✅
Photo	1st att ✅	Remove file	clean	✅	✅
Photo	1st att ❌	Keep file	file	✅	✅	sdcard > Android > data > com.owncloud.android > cache
Photo	2nd att ✅	Remove file	clean	✅	✅	sdcard > Android > data > com.owncloud.android > cache
Shortcut	1st att ✅	Remove file	clean	✅	✅
Shortcut	1st att ❌	Keep file	file	✅	✅	sdcard > Android > data > com.owncloud.android > cache
Shortcut	2nd att ✅	Remove file	clean	✅	✅	sdcard > Android > data > com.owncloud.android > cache
Auto Keep	1st att ✅	Keep file	clean	✅	✅
Auto Keep	1st att ❌	Keep file	file	✅	✅
Auto Keep	2nd att ✅	Keep file	clean	✅	✅
Auto Rem.	1st att ✅	Remove file	clean	✅	✅
Auto Rem.	1st att ❌	Keep file	file	✅	✅
Auto Rem.	2nd att ✅	Remove file	clean	✅	✅
External	1st att ✅	Keep file	clean	✅	✅
External	1st att ❌	Keep file	file	✅	✅
External	2nd att ✅	Keep file	clean	✅	✅

---

Automatic retry

Connectivity loss

Scenario	Outcome	Local source	/tmp	oC10	oCIS	Comment
Manual	1st att ❌	Keep file	file	✅	✅	No pic in /tmp because ENQUEUED status
Manual	2nd att ✅	Keep file	clean	✅	✅
Photo	1st att ❌	Keep file	file	✅	✅	sdcard > Android > data > com.owncloud.android > cache
Photo	2nd att ✅	Remove file	clean	✅	✅	sdcard > Android > data > com.owncloud.android > cache
Shortcut	1st att ❌	Keep file	file	✅	✅	sdcard > Android > data > com.owncloud.android > cache
Shortcut	2nd att ✅	Remove file	clean	✅	✅	sdcard > Android > data > com.owncloud.android > cache
Auto Keep	1st att ❌	Keep file	file	✅	✅	No pic in /tmp because ENQUEUED status
Auto Keep	2nd att ✅	Keep file	clean	✅	✅
Auto Rem.	1st att ❌	Keep file	file	✅	✅	No pic in /tmp because ENQUEUED status
Auto Rem.	2nd att ✅	Remove file	clean	✅	✅
External	1st att ❌	Keep file	file	✅	✅
External	2nd att ✅	Keep file	clean	✅	✅

Corner cases:

• Manual upload + manual retry + automatic retry + success ✅
• Manual upload + automatic retry + manual retry + success ✅
• Auto upload + manual retry + automatic retry + success ✅
• Auto upload + automatic retry + manual retry + success ✅
• Photo upload + manual retry + automatic retry + success ✅
• Photo upload + automatic retry + manual retry + success ✅

[jesmrec]

This is approved on my side 👍

Just one detail to take in account: when lack of connectivity, uploads are enqueued (not failed). Under such status, manual and automatic uploads don't copy the files to upload to /tmp folder, but the uploads from external app. The final status of the upload after retries and success is always correct.

Will update the test plan with that.

[joragua]

For manual and automatic uploads, files are copied to /tmp folder once the network connection is restored and the worker (UploadFilesFromContentUriWorker) executes its doWork() method.

For uploads from external apps, the files are copied to /tmp folder before triggering the use case (UploadFileFromSystemUseCase). This is because this use case only supports string URLs (not content uris) Therefore a temporary file must be created before executing it.