[FEATURE REQUEST] Custom value in space quota (creation and edition)

[joragua]

Related Issues

App: #4688

• Add changelog files for the fixed issues in folder changelog/unreleased. More info here
• Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

---

QA

#4694 (comment)

Reports:

• (1) Edit quota to No restriction not working [FEATURE REQUEST] Custom value in space quota (creation and edition) #4694 (comment) [FIXED]
• (2) Decimal in integer values [FEATURE REQUEST] Custom value in space quota (creation and edition) #4694 (comment) [DONE]
• (3) Floating button formats for small values [FEATURE REQUEST] Custom value in space quota (creation and edition) #4694 (comment) [FIXED]
• (4) Set initial value for quota [FEATURE REQUEST] Custom value in space quota (creation and edition) #4694 (comment) [FIXED]

[jesmrec]

Good job @joragua. Just a few comments to review

[jesmrec]

LGTM 👍

[jesmrec]

QA

Test plans templates on create and edit quota have been modified to adapt the new way to handle the quota

Checks:

1. Create Quota

• No restriction
• 0 GB (not allowed)
• 0,00001 GB [FEATURE REQUEST] Custom value in space quota (creation and edition) #4694 (comment) [FIXED]
• 0,3 GB
• 1 GB
• 2 GB
• 100 GB
• 14677,23456 GB
• 1000000 GB
• 1000001 GB (exceeded)
• empty (not allowed)
• negative (not possible)

2. Edit Quota

• Change to "No restriction" [FEATURE REQUEST] Custom value in space quota (creation and edition) #4694 (comment) [FIXED]
• Change to 0 GB (not allowed)
• Change to 0,00001 GB [FEATURE REQUEST] Custom value in space quota (creation and edition) #4694 (comment) [FIXED]
• Change to 0,3 GB
• Change to 1 GB [FEATURE REQUEST] Custom value in space quota (creation and edition) #4694 (comment) [FIXED]
• Change to 2 GB
• Change to 100 GB
• Change to 4677,23456 GB
• Change to 1000000 GB
• Change to 1000001 GB (exceeded)
• Change to empty (not allowed)
• Change to negative (not possible)

3. Permission

• Space manager (no platform admin), not allowed

4. Accessibility

• Talkback
• Keyboard navigation

[jesmrec]

(1) [FIXED]

1. Create an space with a quota value, f. ex, 1 GB
2. In the Android app, open Edit Space
3. Switch off the quota and Save

Current:

not modified. the PATCH request sends:

{
    "description": "",
    "name": "test",
    "quota": {
        "total": 1000000
    }
}

Expected:

quota modified to No restricted and sent a 0 in the total field

Xiaomi Redmi Note 13
ec6f9ba2

[jesmrec]

(2) (improvement) [DONE]

The Edit space dialog shows the quota value with one decimal, like 25.0 GB . The decimal value could be hidden for "integer" values and only displayed if it's long. What do you mean?

Xiaomi Redmi Note 13
ec6f9ba2

[jesmrec]

(3) [FIXED]

1. Set quota to a very small value like 0,00001
2. Edit space

Current:

Quota displayed in floating point 1.0E-5 GB

Expected:

Quota in decimal format like 0,00001

Xiaomi Redmi Note 13
ec6f9ba2

[joragua]

All reports should be fixed with the new commits, @jesmrec! ✅

[jesmrec]

(4) [FIXED]

1. Click on FAB to create a new space
2. Switch on the quota

In first instance, quota value is empty. As server sets 1GB as default quota, we could set this value as initial quota

Xiaomi Redmi Note 13
c146af2ff

[jesmrec]

about (4), it works fine in creation but in edition. I mean, creating an space with "No restriction", and editing the space by enabling the quota, shows the field empty.

[jesmrec]

Approved on my side, great job!