-
Notifications
You must be signed in to change notification settings - Fork 3.1k
[FEATURE REQUEST] Disable/Remove space #4696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a65b3dd to
5bbed02
Compare
owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/SpacesListAdapter.kt
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/SpacesListFragment.kt
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/SpacesListViewModel.kt
Show resolved
Hide resolved
.../com/owncloud/android/data/spaces/datasources/implementation/OCRemoteSpacesDataSourceTest.kt
Show resolved
Hide resolved
...loudData/src/test/java/com/owncloud/android/data/spaces/repository/OCSpacesRepositoryTest.kt
Show resolved
Hide resolved
8da8bf0 to
5695ca2
Compare
|
CR approved!! 🚀 Let's move to QA |
(1) [WONT FIX]
Current:
Expected: Correct refresh. It could be related with #4698 ?? seems to be a similar effect Xiaomi Redmi 13, Android 15 |
|
(1) -> after discussion, it won't be fixed since we assume the role change user -> user light is not supported |
(2) [SERVER ISSUE]
Current: Error Expected: An message like Is that change feasible? Xiaomi Redmi 13, Android 15 |
|
(2) -> The server returns |
|
Approved on my side 💯. Moving forward! |
…proper permissions
5695ca2 to
fc99d03
Compare
fc99d03 to
1de538b
Compare
Related Issues
App: #4611
ReleaseNotesViewModel.ktcreating a newReleaseNote()with String resources (if required)QA
Test plan:
https://github.com/owncloud/QA/blob/master/Mobile/Android/Executions/Release_4.7/Spaces%20-%20Disable%20Remove.md
Reports: