Skip to content

Conversation

@joragua
Copy link
Collaborator

@joragua joragua commented Oct 16, 2025

Related Issues

App: #4611

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

Test plan:

https://github.com/owncloud/QA/blob/master/Mobile/Android/Executions/Release_4.7/Spaces%20-%20Disable%20Remove.md

Reports:

@joragua joragua self-assigned this Oct 16, 2025
@joragua joragua linked an issue Oct 16, 2025 that may be closed by this pull request
15 tasks
@joragua joragua force-pushed the feature/space_lifecycle_operations branch 3 times, most recently from a65b3dd to 5bbed02 Compare October 27, 2025 13:24
@joragua joragua marked this pull request as ready for review October 28, 2025 09:57
@joragua joragua requested a review from jesmrec October 28, 2025 10:04
@joragua joragua force-pushed the feature/space_lifecycle_operations branch from 8da8bf0 to 5695ca2 Compare October 28, 2025 16:20
@joragua joragua requested a review from jesmrec October 28, 2025 16:41
@jesmrec
Copy link
Collaborator

jesmrec commented Oct 28, 2025

CR approved!! 🚀

Let's move to QA

@jesmrec
Copy link
Collaborator

jesmrec commented Oct 29, 2025

(1) [WONT FIX]

  1. Login with an existing user (with role User) that has one space available
  2. Check the Spaces view -> space is listed
  3. In the web admin dashboard, change the user to User Light
  4. Refresh the view without browsing or killing the app

Current:

server could not be reached

Expected:

Correct refresh. It could be related with #4698 ?? seems to be a similar effect

Xiaomi Redmi 13, Android 15
5695ca2c1e

@jesmrec
Copy link
Collaborator

jesmrec commented Oct 29, 2025

(1) -> after discussion, it won't be fixed since we assume the role change user -> user light is not supported

@jesmrec
Copy link
Collaborator

jesmrec commented Oct 29, 2025

(2) [SERVER ISSUE]

  1. An space manager opens 3-dot-button over an enabled space
  2. Before any operation, another space manager revokes manager permission and turns him to editor
  3. In app, click on Disable and YES

Current:

Error it was not found in snackbar, but the space is visible and accessible

Expected:

An message like Permission error may fit better to that error. it was not found makes more sense if the space is no longer available or visible.

Is that change feasible?

Xiaomi Redmi 13, Android 15
5695ca2c1e

@joragua
Copy link
Collaborator Author

joragua commented Oct 29, 2025

(2) -> The server returns 404 status code instead of 401, so the snackbar message says it was not found. Based on that, I think the bug is on the server side and not in our implementation. 🤔

@jesmrec
Copy link
Collaborator

jesmrec commented Oct 29, 2025

Approved on my side 💯. Moving forward!

@joragua joragua force-pushed the feature/space_lifecycle_operations branch from 5695ca2 to fc99d03 Compare October 29, 2025 11:31
@joragua joragua force-pushed the feature/space_lifecycle_operations branch from fc99d03 to 1de538b Compare October 29, 2025 11:31
@joragua joragua merged commit 8db3f87 into master Oct 29, 2025
11 checks passed
@joragua joragua deleted the feature/space_lifecycle_operations branch October 29, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Disable/Remove space

4 participants