Skip to content

[FIX] Fix for new steps versions in GH Actions #4702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jesmrec merged 3 commits into from
Oct 29, 2025
Merged

[FIX] Fix for new steps versions in GH Actions #4702

jesmrec merged 3 commits into from
Oct 29, 2025
+17 −2

Conversation

@jesmrec
Copy link
Collaborator

@jesmrec jesmrec commented Oct 28, 2025 •
edited
Loading

  • Specify shell to execute apk signing: it assures that the signing is performed in the correct way since runners could choose another one.
  • Set secret as env variables: more robust

Related Issues

App:

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@jesmrec jesmrec self-assigned this Oct 28, 2025
@jesmrec jesmrec requested a review from joragua October 28, 2025 15:36
@jesmrec jesmrec marked this pull request as ready for review October 28, 2025 16:09
joragua
joragua approved these changes Oct 29, 2025
View reviewed changes
Copy link
Collaborator

@joragua joragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@jesmrec jesmrec merged commit cfb23ab into master Oct 29, 2025
11 of 13 checks passed
@jesmrec jesmrec deleted the fix/fix_new_versions_steps branch October 29, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joragua joragua joragua approved these changes

Assignees

@jesmrec jesmrec

Labels

Estimation - 2 (S) GitHub Actions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jesmrec @joragua @ownclouders