Skip to content

[TECHNICAL] Workflow that builds an unsigned app with version and variant#4751

Merged
jesmrec merged 4 commits intomasterfrom
feature/actions_generic_workflow_build_app
Jan 12, 2026
Merged

[TECHNICAL] Workflow that builds an unsigned app with version and variant#4751
jesmrec merged 4 commits intomasterfrom
feature/actions_generic_workflow_build_app

Conversation

@jesmrec
Copy link
Collaborator

@jesmrec jesmrec commented Jan 9, 2026 •
edited
Loading

Reusable workflow to be called for any other workflow to get an apk artifact to be used in testing or any other purposes. Artifact is unsigned, since the keys and the keystore are responsibility on the calling workflow.

Inputs: build variant and commit/tag/branch

Related Issues

App:

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@jesmrec jesmrec self-assigned this Jan 9, 2026
@jesmrec jesmrec changed the title [FEATURE] Workflow that builds an unsigned app with version and variant [FEATURE REQUEST] Workflow that builds an unsigned app with version and variant Jan 9, 2026
@jesmrec jesmrec changed the title [FEATURE REQUEST] Workflow that builds an unsigned app with version and variant [TECHNICAL] Workflow that builds an unsigned app with version and variant Jan 9, 2026
@jesmrec jesmrec force-pushed the feature/actions_generic_workflow_build_app branch from de6b276 to 0cc24e7 Compare January 12, 2026 07:55
@jesmrec jesmrec marked this pull request as ready for review January 12, 2026 08:04
@jesmrec jesmrec requested a review from joragua January 12, 2026 08:04
joragua
joragua requested changes Jan 12, 2026
View reviewed changes
Copy link
Collaborator

@joragua joragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @jesmrec 💯 Somme comments here:

NOTE: I would rename the workflow to build-apk.yml in order to follow the naming convention used for workflows in the repository.

@jesmrec
Copy link
Collaborator Author

jesmrec commented Jan 12, 2026

NOTE: I would rename the workflow to build-apk.yml in order to follow the naming convention used for workflows in the repository.

will do, in order to keep consistency as well

@jesmrec jesmrec force-pushed the feature/actions_generic_workflow_build_app branch from 2e9dc0b to fcf3aeb Compare January 12, 2026 09:45
@jesmrec jesmrec requested a review from joragua January 12, 2026 09:55
joragua
joragua approved these changes Jan 12, 2026
View reviewed changes
Copy link
Collaborator

@joragua joragua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@jesmrec jesmrec merged commit af6c34b into master Jan 12, 2026
10 checks passed
@jesmrec jesmrec deleted the feature/actions_generic_workflow_build_app branch January 12, 2026 10:11
jesmrec added a commit that referenced this pull request Jan 15, 2026
@jesmrec
Merge pull request #4751 from owncloud/feature/actions_gen
f88f51b
@joragua joragua removed the Sprint label Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joragua joragua joragua approved these changes

Assignees

@jesmrec jesmrec

Labels

Estimation - 3 (M) GitHub Actions Technical

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jesmrec @joragua @ownclouders