[FEATURE REQUEST] Add a member to a space: Set permissions and expiration date#4764
Merged
[FEATURE REQUEST] Add a member to a space: Set permissions and expiration date#4764
Conversation
10 tasks
4a42584 to
b4a9d4e
Compare
jesmrec
requested changes
Feb 4, 2026
owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/members/AddMemberFragment.kt
Show resolved
Hide resolved
owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/members/AddMemberFragment.kt
Show resolved
Hide resolved
...dApp/src/main/java/com/owncloud/android/presentation/spaces/members/SearchMembersDiffUtil.kt
Show resolved
Hide resolved
...oudApp/src/main/java/com/owncloud/android/presentation/spaces/members/SpaceMembersAdapter.kt
Show resolved
Hide resolved
...ibrary/src/main/java/com/owncloud/android/lib/resources/members/services/OCMembersService.kt
Show resolved
Hide resolved
...Library/src/main/java/com/owncloud/android/lib/resources/members/AddRemoteMemberOperation.kt
Outdated
Show resolved
Hide resolved
190985b to
8015290
Compare
Collaborator
|
CR Approved, moving to QA |
jesmrec
approved these changes
Feb 6, 2026
Collaborator
(1)
Current: Current user, that was an space Expected: Option to add new members should be gone when view is reloaded and user is no longer a Xiaomi Redmi Note 13, Android 15 |
Collaborator
Author
|
(1) should be fixed with the last commit @jesmrec 😄 |
Collaborator
(2) [WONT FIX]question: About talkback: opening the date picker and browser through different months, talkback dictates: |
Collaborator
|
(1) fixed |
Collaborator
Author
|
Regarding (2): |
Collaborator
|
(2) -> wont fix |
Collaborator
|
Approved |
7dc02c4 to
df4da6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
App: #4740
ReleaseNotesViewModel.ktcreating a newReleaseNote()with String resources (if required)QA
Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Executions/Release_4.8/Spaces%20-%20Add%20member.md
Reports:
+button is visible when user is no longer aManager[FEATURE REQUEST] Add a member to a space: Set permissions and expiration date #4764 (comment) [FIXED]