Skip to content

[FEATURE REQUEST] Add a member to a space: Set permissions and expiration date#4764

Merged
joragua merged 12 commits intomasterfrom
feature/add_a_member_to_a_space
Feb 6, 2026
Merged

[FEATURE REQUEST] Add a member to a space: Set permissions and expiration date#4764
joragua merged 12 commits intomasterfrom
feature/add_a_member_to_a_space

Conversation

@joragua
Copy link
Collaborator

@joragua joragua commented Feb 3, 2026

Related Issues

App: #4740

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

Test plan: https://github.com/owncloud/QA/blob/master/Mobile/Android/Executions/Release_4.8/Spaces%20-%20Add%20member.md

Reports:

@joragua joragua self-assigned this Feb 3, 2026
@joragua joragua linked an issue Feb 3, 2026 that may be closed by this pull request
10 tasks
@joragua joragua force-pushed the feature/add_a_member_to_a_space branch from 4a42584 to b4a9d4e Compare February 4, 2026 10:45
@joragua joragua marked this pull request as ready for review February 4, 2026 11:54
@joragua joragua requested a review from jesmrec February 4, 2026 11:54
@joragua joragua force-pushed the feature/add_a_member_to_a_space branch from 190985b to 8015290 Compare February 5, 2026 08:34
@joragua joragua requested a review from jesmrec February 5, 2026 13:17
@jesmrec
Copy link
Collaborator

jesmrec commented Feb 6, 2026

CR Approved, moving to QA

@jesmrec
Copy link
Collaborator

jesmrec commented Feb 6, 2026

(1)

  1. Space Manager opens Members
  2. Click on + and search for members
  3. Select a member and give any permission
  4. Before submitting, Manager is downgraded to Editor/Viewer
  5. Click on Invite -> snackbar with error ✅
  6. Click on back arrow on the top

Current:

Current user, that was an space Manager is not Manager anymore. But, the + button to add new member is still visible

Expected:

Option to add new members should be gone when view is reloaded and user is no longer a Manager

Xiaomi Redmi Note 13, Android 15
41f85664

@joragua
Copy link
Collaborator Author

joragua commented Feb 6, 2026

(1) should be fixed with the last commit @jesmrec 😄

@jesmrec
Copy link
Collaborator

jesmrec commented Feb 6, 2026

(2) [WONT FIX]

question:

About talkback: opening the date picker and browser through different months, talkback dictates: page 4 of 899 . I know that DatePicker is native, but i have to ask if that could be improved.

@jesmrec
Copy link
Collaborator

jesmrec commented Feb 6, 2026

(1) fixed

@joragua
Copy link
Collaborator Author

joragua commented Feb 6, 2026

Regarding (2): page X of Y cannot be removed because it is handled internally by Android

@jesmrec
Copy link
Collaborator

jesmrec commented Feb 6, 2026

(2) -> wont fix

@jesmrec
Copy link
Collaborator

jesmrec commented Feb 6, 2026

Approved

@joragua joragua force-pushed the feature/add_a_member_to_a_space branch from 7dc02c4 to df4da6d Compare February 6, 2026 13:31
@joragua joragua merged commit a361902 into master Feb 6, 2026
11 checks passed
@joragua joragua deleted the feature/add_a_member_to_a_space branch February 6, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Add a member to a space: Set permissions and expiration date

3 participants