fix the flip stuffs #123
Merged
fix the flip stuffs #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
GoGitOps Review
Grade: A+ (98.4%)
Files: 37
Issues: 5
gofmt: 100%
go_vet: 100%
gocyclo: 97%
internal/eventhttphandler/gesture_handler.go
Line 60: warning: cyclomatic complexity 16 of function (*GestureHandler).ServeHTTP() is high (> 15) (gocyclo)
golint: 89%
internal/remarkable/fb_rm.go
Line 10: warning: exported function GetFileAndPointer should have comment or be unexported (golint)
http.go
Line 98: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
internal/remarkable/const.go
Line 6: warning: exported const Model should have comment (or a comment on this block) or be unexported (golint)
internal/remarkable/const.go
Line 15: warning: comment on exported const MaxXValue should be of the form "MaxXValue ..." (golint)
internal/remarkable/device.go
Line 3: warning: exported type DeviceModel should have comment or be unexported (golint)
internal/remarkable/device.go
Line 6: warning: exported const UnknownDevice should have comment (or a comment on this block) or be unexported (golint)
license: 100%
ineffassign: 100%
misspell: 100%
This report was generated using GoGitOps.
There was a problem hiding this comment.
GoGitOps Review
Grade: A+ (98.4%)
Files: 37
Issues: 5
gofmt: 100%
go_vet: 100%
gocyclo: 97%
internal/eventhttphandler/gesture_handler.go
Line 60: warning: cyclomatic complexity 16 of function (*GestureHandler).ServeHTTP() is high (> 15) (gocyclo)
golint: 89%
internal/remarkable/fb_rm.go
Line 10: warning: exported function GetFileAndPointer should have comment or be unexported (golint)
http.go
Line 98: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
internal/remarkable/const.go
Line 6: warning: exported const Model should have comment (or a comment on this block) or be unexported (golint)
internal/remarkable/const.go
Line 15: warning: comment on exported const MaxXValue should be of the form "MaxXValue ..." (golint)
internal/remarkable/device.go
Line 3: warning: exported type DeviceModel should have comment or be unexported (golint)
internal/remarkable/device.go
Line 6: warning: exported const UnknownDevice should have comment (or a comment on this block) or be unexported (golint)
license: 100%
ineffassign: 100%
misspell: 100%
This report was generated using GoGitOps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.