Prevent finding PID of xochitl_pdf_renderer when seeking framebuffer #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the Remarkable Paper Pro support when launching the process with a PDF or ePub file open. When one of these files is open the process
/usr/bin/xochitl_pdf_rendereris running, causing thefindXochitlPIDfunction to fetch its PID instead of/usr/bin/xochitl's PID. Having found the wrong process, the tool is therefore unable to find the framebuffer and exits withfailed to get memory range: no mapping found for /dev/dri/card0.This PR changes the
findXochitlPIDfunction to look for exactly/usr/bin/xochitlinstead of usingcontains.I have not tested this change on a ReMarkable 2.