Conversation
rowanc1
commented
Dec 22, 2025
|
|
||
| # Build oxa (copy bundled CLI) | ||
| - run: pnpm --filter oxa build | ||
| - run: pnpm test |
Member
Author
There was a problem hiding this comment.
This is the nice thing about using turbo, we don't have to remember the order of these now!
Comment on lines
+24
to
+26
| "format": "prettier --write \"src/**/*.ts\"", | ||
| "format:check": "prettier --check \"src/**/*.ts\"", | ||
| "lint": "eslint .", |
Member
Author
There was a problem hiding this comment.
I moved these down and made the prettier more specific. The previous was fixing and linting in the dist folder as well.
Comment on lines
+28
to
+30
| "devDependencies": { | ||
| "@oxa/core": "workspace:*" | ||
| }, |
Member
Author
There was a problem hiding this comment.
Adding the devDep here, which means this will wait for the other to build.
Comment on lines
+15
to
+21
| "format": "turbo format", | ||
| "format:check": "turbo format:check", | ||
| "lint": "turbo lint", | ||
| "lint:fix": "turbo lint:fix", | ||
| "build": "turbo build", | ||
| "test": "turbo test", | ||
| "clean": "turbo clean" |
Member
Author
There was a problem hiding this comment.
Added all these commands as turbo.
Member
Author
|
@nokome Goign to go ahead and merge this one in, mostly just changing package locks etc to use turbo, which adds caching and dependencies across the various packages so builds are more consistent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.