perf(language_server): transform `Message` to `DiagnosticReport` with one call #14448

Sysix · 2025-10-08T18:13:53Z

The struct MessageWithPosition is not needed anymore. oxc_linter is sending Message and the server is storing DiagnosticReport. So we can save the transformation Message -> MessageWithPositoin -> DiagnosticReport and transform direct: Message -> DiagnosticReport.

Removed all relevant code and implemented message_to_diagnostic_report.

related #14563

Sysix · 2025-10-08T18:14:12Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull Request Overview

This PR optimizes the language server's diagnostic transformation by eliminating an intermediate data structure. It removes the MessageWithPosition struct and transforms Message directly to DiagnosticReport, simplifying the conversion pipeline from Message -> MessageWithPosition -> DiagnosticReport to Message -> DiagnosticReport.

Removed intermediate MessageWithPosition struct and related helper types
Implemented direct transformation function message_to_lsp_diagnostic
Updated call sites to use the new direct transformation approach

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
`crates/oxc_language_server/src/linter/tsgo_linter.rs`	Updated to use direct message transformation and changed iterator from `into_iter()` to `iter()`
`crates/oxc_language_server/src/linter/isolated_lint_handler.rs`	Updated to use direct message transformation and changed iterator from `into_iter()` to `iter()`
`crates/oxc_language_server/src/linter/error_with_position.rs`	Major refactoring to remove intermediate types and implement direct transformation

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

crates/oxc_language_server/src/linter/error_with_position.rs

graphite-app · 2025-10-13T14:41:34Z

Merge activity

Oct 13, 2:41 PM UTC: camc314 added this pull request to the Graphite merge queue.
Oct 13, 2:51 PM UTC: Merged by the Graphite merge queue.

… one call (#14448) The struct `MessageWithPosition` is not needed anymore. `oxc_linter` is sending `Message` and the server is storing `DiagnosticReport`. So we can save the transformation `Message -> MessageWithPositoin -> DiagnosticReport` and transform direct: `Message -> DiagnosticReport`. Removed all relevant code and implemented `message_to_diagnostic_report`. related https://github.com/oxc-project/backlog/issues/175

## [1.23.0] - 2025-10-13 ### 🚀 Features - 452d128 linter: Node/no_process_env (#14536) (Kenneth Skovhus) - a9e1261 linter: Implement react-refresh/only-export-components (#14122) (Rintaro Itokawa) - a8d542b linter/no-duplicate-imports: Support `allowSeparateTypeImports` option (#14527) (camc314) - 75a529c linter: Add run info about what functions rules implement (#13839) (camchenry) - 4fbdef2 language_server: Support `fmt.configPath` configuration (#14502) (Sysix) - 4d3ce2e language_server: Autodetect root `.oxfmtrc.json` (#14466) (Sysix) ### 🐛 Bug Fixes - fb4a20d language_server: Add whitespace for `// oxlint-disable-next-line` fix (#14356) (Sysix) - 6fce7f4 oxlint/changelog: Remove duplicate changelog entries (#14528) (camc314) - 74e52f3 linter/plugins: Resolve JS plugins with ESM condition names (#14541) (magic-akari) - 9965676 linter/exhaustive-deps: Ignore empty strings passed to `additionalHooks` option (#14464) (Redas) - d0a8e3e linter: `vue/no_required_prop_with_default` called `Option::unwrap()` on a `None` value (#14491) (Sysix) - 1192ea2 linter: Correct `nextjs/no-typos` path handling (#14480) (shulaoda) - 2796b16 tsgolint: Pipe tsgolints stderr (#14477) (camc314) ### 🚜 Refactor - 6440cde linter: Remove lifetime of `Message` (#14481) (Sysix) - f599bef language_server: Move `Message` to `DiagnosticReport` transformation to one place (#14447) (Sysix) - 4f301de napi/parser, linter/plugins: Improve formatting of generated code (#14554) (overlookmotel) - 68c0252 napi/parser, linter/plugins: Shorten generated raw transfer deserializer code (#14553) (overlookmotel) - 20e884e linter: Store `LintService` in `LintRunner` (#14471) (Sysix) - 9e9c5ba linter: Simplify built-in lint plugin checks (#14518) (camchenry) - 1986e0f linter/no-ex-assign: Use let-else chain (#14526) (camc314) - ce9bcf0 linter/no-func-assign: Use let-else chain (#14525) (camc314) - a9cea7c language_server: Use `FxHashSet` for `ServerLinter::extended_paths` (#14517) (Sysix) - ea5838e linter/no-import-assign: Use let-else chain (#14524) (camc314) - f977700 language_server: Pass `LintOptions` to `Worker::refresh_server_linter` (#14510) (Sysix) - 54b001f linter/no-new-require: Improve diagnostic message clarity (#14511) (shulaoda) - 650ea68 linter: Improve nextjs/no-typos rule (#14476) (shulaoda) ### 📚 Documentation - 198f2e9 linter: Fix code example for `branches-sharing-code` (#14514) (camc314) - d776a17 linter: Improve `nextjs/no-typos` rule documentation (#14470) (shulaoda) ### ⚡ Performance - b44a30e language_server: Transform `Message` to `DiagnosticReport` with one call (#14448) (Sysix) - 31766fd linter/plugins: Provide `loc` via prototype (#14552) (overlookmotel) - aec0c08 linter: Allow analyzing node types in match blocks with guards (#14459) (camchenry) - 9044187 linter: Skip running node-specific rule if file contains no relevant nodes (#14457) (camchenry) - 422f54e linter: Only run rule run functions if implemented (#14454) (camchenry) - 2c228ae liner: Use top-level match for `no_obj_calls` (#14523) (camchenry) - c49d891 linter: Use match for `no_negated_condition` (#14522) (camchenry) - e222fc2 linter: Use match for `no_multi_assign` (#14521) (camchenry) - 4440516 linter: Refactor rules to take advantage of node type skipping (#14519) (camchenry) - 78261d6 linter: Refactor `no-invalid-fetch-options` to be more easily analyzed (#14458) (camchenry) ### 🧪 Testing - 8d8881d linter/plugins: Expand tests for module resolution of plugins (#14559) (overlookmotel) - 33b6cde language_server: Add basic tests for `WorkspaceWorker::did_change_configuration` (#14531) (Sysix) - bfe1ecd language_server: Add tests for `WorkspaceWorker::init_watchers` (#14516) (Sysix) Co-authored-by: camc314 <[email protected]>

github-actions bot added A-editor Area - Editor and Language Server C-performance Category - Solution not expected to change functional behavior, only performance labels Oct 8, 2025

This was referenced Oct 8, 2025

fix(language_server): add whitespace for // oxlint-disable-next-line fix #14356

Merged

refactor(language_server): move Message to DiagnosticReport transformation to one place #14447

Merged

Sysix force-pushed the 10-08-perf_language_server_transform_message_to_diagnosticreport_with_one_call branch from f821c90 to dc2ad61 Compare October 8, 2025 18:49

Sysix requested a review from Copilot October 8, 2025 19:12

Copilot AI reviewed Oct 8, 2025

View reviewed changes

crates/oxc_language_server/src/linter/error_with_position.rs Outdated Show resolved Hide resolved

crates/oxc_language_server/src/linter/error_with_position.rs Show resolved Hide resolved

Sysix force-pushed the 10-08-perf_language_server_transform_message_to_diagnosticreport_with_one_call branch from dc2ad61 to 77938e4 Compare October 8, 2025 19:18

Sysix marked this pull request as ready for review October 8, 2025 19:22

Sysix requested a review from camc314 as a code owner October 8, 2025 19:22

This was referenced Oct 10, 2025

refactor(linter): remove lifetime of Message #14481

Merged

refactor(linter): remove unused allocator param in Runtime for LSP & tests #14489

Merged

Sysix force-pushed the 10-08-perf_language_server_transform_message_to_diagnosticreport_with_one_call branch from 77938e4 to b9e101e Compare October 12, 2025 12:09

Sysix force-pushed the 10-08-refactor_language_server_move_message_to_diagnosticreport_transformation_to_one_place branch from b8a71b0 to 9bb5a61 Compare October 12, 2025 12:09

camc314 self-assigned this Oct 13, 2025

camc314 approved these changes Oct 13, 2025

View reviewed changes

graphite-app bot force-pushed the 10-08-refactor_language_server_move_message_to_diagnosticreport_transformation_to_one_place branch from 9bb5a61 to f599bef Compare October 13, 2025 14:46

graphite-app bot force-pushed the 10-08-perf_language_server_transform_message_to_diagnosticreport_with_one_call branch from b9e101e to b44a30e Compare October 13, 2025 14:47

Base automatically changed from 10-08-refactor_language_server_move_message_to_diagnosticreport_transformation_to_one_place to main October 13, 2025 14:50

graphite-app bot merged commit b44a30e into main Oct 13, 2025
22 checks passed

graphite-app bot deleted the 10-08-perf_language_server_transform_message_to_diagnosticreport_with_one_call branch October 13, 2025 14:51

Boshen mentioned this pull request Oct 13, 2025

release(oxlint): v1.23.0 #14560

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

perf(language_server): transform `Message` to `DiagnosticReport` with one call #14448

perf(language_server): transform `Message` to `DiagnosticReport` with one call #14448

Uh oh!

Sysix commented Oct 8, 2025 •

edited

Loading

Uh oh!

Sysix commented Oct 8, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

graphite-app bot commented Oct 13, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

perf(language_server): transform Message to DiagnosticReport with one call #14448

perf(language_server): transform Message to DiagnosticReport with one call #14448

Uh oh!

Conversation

Sysix commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Sysix commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

graphite-app bot commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

perf(language_server): transform `Message` to `DiagnosticReport` with one call #14448

perf(language_server): transform `Message` to `DiagnosticReport` with one call #14448

Sysix commented Oct 8, 2025 •

edited

Loading

Sysix commented Oct 8, 2025 •

edited

Loading

graphite-app bot commented Oct 13, 2025 •

edited

Loading