Skip to content

fix(linter/plugins): resolve JS plugins with ESM condition names #14541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 13, 2025
Merged

fix(linter/plugins): resolve JS plugins with ESM condition names #14541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7affe94
fix(linter/plugins): resolve JS plugins with ESM condition names
magic-akari Oct 12, 2025
25f0878
chore: add test cases
magic-akari Oct 13, 2025
0fc2b0b
fix: correcrt `main_fields` and `condition_names`
magic-akari Oct 13, 2025
a77a8c2
chore: update snapshot
magic-akari Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions apps/oxlint/test/fixtures/load_paths/.oxlintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@
"./plugins/plugin6.mts",
"./plugins/plugin7",
"plugin8",
"plugin9"
"plugin9",
"plugin10"
],
"rules": {
"plugin1/no-debugger": "error",
Expand All @@ -19,6 +20,7 @@
"plugin6/no-debugger": "error",
"plugin7/no-debugger": "error",
"plugin8/no-debugger": "error",
"plugin9/no-debugger": "error"
"plugin9/no-debugger": "error",
"plugin10/no-debugger": "error"
}
}
21 changes: 21 additions & 0 deletions apps/oxlint/test/fixtures/load_paths/node_modules/plugin10/index.cjs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 19 additions & 0 deletions apps/oxlint/test/fixtures/load_paths/node_modules/plugin10/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions apps/oxlint/test/fixtures/load_paths/node_modules/plugin10/package.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 7 additions & 1 deletion apps/oxlint/test/fixtures/load_paths/output.snap.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,12 @@
: ^^^^^^^^^
`----

x plugin10(no-debugger): Unexpected Debugger Statement
,-[files/index.js:1:1]
1 | debugger;
: ^^^^^^^^^
`----

x plugin2(no-debugger): Unexpected Debugger Statement
,-[files/index.js:1:1]
1 | debugger;
Expand Down Expand Up @@ -64,7 +70,7 @@
: ^^^^^^^^^
`----

Found 1 warning and 9 errors.
Found 1 warning and 10 errors.
Finished in Xms on 1 file using X threads.
```

Expand Down
8 changes: 6 additions & 2 deletions crates/oxc_linter/src/config/config_builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use std::{
};

use itertools::Itertools;
use oxc_resolver::Resolver;
use oxc_resolver::{ResolveOptions, Resolver};
use rustc_hash::{FxHashMap, FxHashSet};

use oxc_span::{CompactStr, format_compact_str};
Expand Down Expand Up @@ -169,7 +169,11 @@ impl ConfigStoreBuilder {
return Err(ConfigBuilderError::NoExternalLinterConfigured { plugin_specifier });
};

let resolver = Resolver::default();
let resolver = Resolver::new(ResolveOptions {
main_fields: vec!["module".into(), "main".into()],
condition_names: vec!["module".into(), "import".into()],
..Default::default()
});

#[expect(clippy::missing_panics_doc, reason = "oxlintrc.path is always a file path")]
let oxlintrc_dir = oxlintrc.path.parent().unwrap();
Expand Down
Loading