feat(napi/minify): expose join_vars, sequences, and max_iterations options #14545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
IWANABETHATGUY
changed the title
IWANABETHATGUY
force-pushed
the
10-13-feat_expose_more_options_in_oxc_minify_napi
branch
2 times, most recently
from
3ba2ae0 to
b43e59e
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR exposes three minification options (join_vars, sequences, and passes) in the NAPI minify interface to provide more granular control over the compression behavior. The change replaces hardcoded values with configurable options that can be passed from JavaScript.
- Adds three new optional fields to CompressOptions struct with proper documentation
- Updates the TryFrom implementation to use the new configurable options instead of hardcoded values
- Maps the JavaScript-friendly "passes" parameter to the internal "max_iterations" field
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
IWANABETHATGUY
force-pushed
the
10-13-feat_expose_more_options_in_oxc_minify_napi
branch
from
dd4d65d to
1e05baa
Compare
Merge activity
|
…tions (#14545) related to rolldown/rolldown#6477 I use `passes` instead of `max_iterations` since `passes` is commonly used in the Javascript community, see - terser: https://github.com/terser/terser#:~:text=passes%20(default%3A%201)%20%2D%2D%20The%20maximum%20number%20of%20times%20to%20run%20compress.%20In%20some%20cases%20more%20than%20one%20pass%20leads%20to%20further%20compressed%20code.%20Keep%20in%20mind%20more%20passes%20will%20take%20more%20time. - swc: <img width="626" height="828" alt="image" src="https://github.com/user-attachments/assets/aabc2e10-59a1-43ab-b9e0-52ab35522f85" />
graphite-app
bot
force-pushed
the
10-13-feat_expose_more_options_in_oxc_minify_napi
branch
from
1e05baa to
c19c9ec
Compare
graphite-app
bot
deleted the
10-13-feat_expose_more_options_in_oxc_minify_napi
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to rolldown/rolldown#6477
I use
passesinstead ofmax_iterationssincepassesis commonly used in the Javascript community,see