Skip to content

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Nov 18, 2025

grafik

related #14826

@Sysix Sysix changed the title draft(oxlnt/lsp): support jsPlugins draft(oxlint/lsp): support jsPlugins Nov 18, 2025
@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI A-editor Area - Editor and Language Server labels Nov 18, 2025
Copy link
Member Author

Sysix commented Nov 18, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 18, 2025

CodSpeed Performance Report

Merging #15839 will not alter performance

Comparing 11-18-draft_oxlnt_lsp_support_jsplugins_ (62ed619) with 11-25-chore_oxlint_napi_add_createworkspace_destroyworkspace_js_callback_function (ce53742)1

Summary

✅ 4 untouched
⏩ 41 skipped2

Footnotes

  1. No successful run was found on 11-25-chore_oxlint_napi_add_createworkspace_destroyworkspace_js_callback_function (8a4ded6) during the generation of this report, so 4d1596f was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@Sysix Sysix force-pushed the 11-18-draft_oxlnt_lsp_support_jsplugins_ branch 3 times, most recently from 4813d86 to b92081d Compare November 19, 2025 17:11
@Sysix Sysix changed the title draft(oxlint/lsp): support jsPlugins feat(oxlint/lsp): support jsPlugins Nov 19, 2025
@github-actions github-actions bot added the C-enhancement Category - New feature or request label Nov 19, 2025
@Sysix Sysix force-pushed the 11-18-draft_oxlnt_lsp_support_jsplugins_ branch 3 times, most recently from 85415a9 to 374555a Compare November 19, 2025 22:17
@github-actions github-actions bot added the A-linter-plugins Area - Linter JS plugins label Nov 19, 2025
// This allows re-loading the plugin when the linter is restarted in `--lsp` mode.
if (registeredPluginPaths.has(path)) {
throw new Error('This plugin has already been registered. This is a bug in Oxlint. Please report it.');
registeredPluginPaths.delete(path);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@overlookmotel I am not sure if this is the right approach.
When changing a .oxlintrc.json file, the server will restart the tool (linter) and re-register all plugins.
I would prefer that each instance get started with an empty registeredPluginPaths, and not share between restarts/workspaces.
But it looks complicated to achieve :(

The main difference from oxlint with jsPlugins and oxlint --lsp is:

@Sysix Sysix force-pushed the 11-18-draft_oxlnt_lsp_support_jsplugins_ branch 2 times, most recently from bf8727d to 8aa94a6 Compare November 24, 2025 13:35
@Sysix Sysix changed the base branch from main to graphite-base/15839 November 26, 2025 19:26
@Sysix Sysix force-pushed the 11-18-draft_oxlnt_lsp_support_jsplugins_ branch from 8aa94a6 to 4b6bcbf Compare November 26, 2025 19:26
@Sysix Sysix changed the base branch from graphite-base/15839 to 11-25-chore_oxlint_napi_add_createworkspace_destroyworkspace_js_callback_function November 26, 2025 19:27
@Sysix Sysix force-pushed the 11-18-draft_oxlnt_lsp_support_jsplugins_ branch from 4b6bcbf to 71bd634 Compare November 26, 2025 19:44
@Sysix Sysix force-pushed the 11-25-chore_oxlint_napi_add_createworkspace_destroyworkspace_js_callback_function branch 2 times, most recently from 5562192 to 5353e40 Compare November 26, 2025 19:59
@Sysix Sysix force-pushed the 11-18-draft_oxlnt_lsp_support_jsplugins_ branch 3 times, most recently from ba45c78 to d595d93 Compare November 27, 2025 15:49
@Sysix Sysix force-pushed the 11-25-chore_oxlint_napi_add_createworkspace_destroyworkspace_js_callback_function branch 2 times, most recently from 1f793f4 to fda5042 Compare November 27, 2025 15:52
@Sysix Sysix force-pushed the 11-18-draft_oxlnt_lsp_support_jsplugins_ branch 2 times, most recently from 9223972 to 150ace0 Compare November 27, 2025 16:34
@Sysix Sysix force-pushed the 11-25-chore_oxlint_napi_add_createworkspace_destroyworkspace_js_callback_function branch from fda5042 to ce53742 Compare November 27, 2025 16:34
@Sysix Sysix force-pushed the 11-25-chore_oxlint_napi_add_createworkspace_destroyworkspace_js_callback_function branch from ce53742 to 8a4ded6 Compare November 27, 2025 16:41
@Sysix Sysix force-pushed the 11-18-draft_oxlnt_lsp_support_jsplugins_ branch from 150ace0 to 62ed619 Compare November 27, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-editor Area - Editor and Language Server A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants