Skip to content

refactor(all): remove binding pattern wierdness #15925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

refactor(all): remove binding pattern wierdness #15925

wants to merge 1 commit into from

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Nov 21, 2025 •
edited
Loading

fixes #11489

estree is failing. need to investigate more this weekend

@camc314 camc314 marked this pull request as ready for review November 21, 2025 00:01
Copilot AI review requested due to automatic review settings November 21, 2025 00:01
@camc314 camc314 requested a review from Dunqing as a code owner November 21, 2025 00:01
@github-actions github-actions bot added A-linter Area - Linter A-parser Area - Parser A-semantic Area - Semantic A-cli Area - CLI A-minifier Area - Minifier A-ast Area - AST A-transformer Area - Transformer / Transpiler A-codegen Area - Code Generation A-isolated-declarations Isolated Declarations A-ast-tools Area - AST tools A-formatter Area - Formatter A-linter-plugins Area - Linter JS plugins labels Nov 21, 2025
@camc314 Graphite App
Copy link
Contributor Author

camc314 commented Nov 21, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Nov 21, 2025
@camc314 camc314 marked this pull request as draft November 21, 2025 00:01
@camc314 camc314 force-pushed the c/11-21-refactor_all_remove_binding_pattern_wierdness branch 5 times, most recently from b41648c to 497689d Compare November 21, 2025 00:05
camc314
camc314 commented Nov 21, 2025
View reviewed changes
crates/oxc_ast/src/ast/js.rs
#[generate_derive(CloneIn, Dummy, TakeIn, GetSpan, GetSpanMut, ContentEq, UnstableAddress)]
pub struct FormalParameterRest<'a> {
pub span: Span,
pub rest: BindingRestElement<'a>,
Copy link
Contributor Author

@camc314 camc314 Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: the future, we can remove the alias of BindingRestElement here

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 21, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #15925 will improve performances by 6.97%

Comparing c/11-21-refactor_all_remove_binding_pattern_wierdness (3f8218e) with main (ef05957)

Summary

⚡ 1 improvement
✅ 41 untouched
⏩ 3 skipped1

Benchmarks breakdown

Mode Benchmark BASE HEAD Change
⚡ Simulation formatter[types.ts] 15.8 ms 14.8 ms +6.97%

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@camc314 camc314 force-pushed the c/11-21-refactor_all_remove_binding_pattern_wierdness branch 2 times, most recently from fb8fd1d to a46b36c Compare November 21, 2025 00:13
@camc314 camc314 force-pushed the c/11-21-refactor_all_remove_binding_pattern_wierdness branch from a46b36c to 08589e7 Compare November 21, 2025 00:13
Copilot AI reviewed Nov 21, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@camc314 camc314 force-pushed the c/11-21-refactor_all_remove_binding_pattern_wierdness branch 24 times, most recently from f38c15a to a4bb016 Compare November 23, 2025 17:36
camc314
camc314 commented Nov 23, 2025
View reviewed changes
Copy link
Contributor Author

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@overlookmotel I got all of the estree/raw transfer tests to pass, but i'm unconvinced i've done it in the most idomatic way as I am very unfamiliar with the code. please feel free to rewrite it

@camc314 camc314 force-pushed the c/11-21-refactor_all_remove_binding_pattern_wierdness branch from a4bb016 to 3f8218e Compare November 23, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@overlookmotel overlookmotel Awaiting requested review from overlookmotel overlookmotel is a code owner

@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

At least 0 approving reviews are required to merge this pull request.

Assignees

@overlookmotel overlookmotel

@camc314 camc314

Labels

A-ast Area - AST A-ast-tools Area - AST tools A-cli Area - CLI A-codegen Area - Code Generation A-formatter Area - Formatter A-isolated-declarations Isolated Declarations A-linter Area - Linter A-linter-plugins Area - Linter JS plugins A-minifier Area - Minifier A-parser Area - Parser A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor BindingPattern to remove weirdness

3 participants

@camc314 @overlookmotel