-
-
Notifications
You must be signed in to change notification settings - Fork 724
fix(linter): fix eslint/sort-imports allowSeparatedGroups not working with single empty line #16012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… with single empty line This fix oxc-project#15990
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
CodSpeed Performance ReportMerging #16012 will not alter performanceComparing Summary
Footnotes
|
| "import b from 'b'; | ||
| import a from 'a';", | ||
| import a from 'a';", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this code should pass the rule even if this import has spaces in front of it. It does in ESLint: https://eslint.org/play/#eyJ0ZXh0IjoiaW1wb3J0IHsgZm9ybWF0IH0gZnJvbSBcIm94Zm10XCI7XG5cbiAgICAgICAgIGltcG9ydCB7IGRlZmluZVJ1bGUgfSBmcm9tIFwib3hsaW50XCI7XG4iLCJvcHRpb25zIjp7InJ1bGVzIjp7InNvcnQtaW1wb3J0cyI6WyJlcnJvciIseyJhbGxvd1NlcGFyYXRlZEdyb3VwcyI6dHJ1ZX1dfSwibGFuZ3VhZ2VPcHRpb25zIjp7InBhcnNlck9wdGlvbnMiOnsiZWNtYUZlYXR1cmVzIjp7fX0sImVjbWFWZXJzaW9uIjoyMDI2fX19
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the change in this test is to fail the previous implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, can we include both still?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I added a new test case instead of modifying the existing one.
525cc0d to
ad331ae
Compare
This fixes #15990