feat(linter/plugins): implement options merging #16217
Merged
+111
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 27, 2025
3 tasks
Member
Author
Merge activity
|
Implement function for merging rule options from config with the rule's default options. This function is not currently used, as we don't have a way to get options from config over from Rust to JS yet, but I've implemented it now, as it's also needed for the rule tester (#16206).
graphite-app
bot
force-pushed
the
11-27-refactor_linter_plugins_split_json_deep_freeze_into_multiple_functions
branch
from
41ceafc to
8881d7f
Compare
graphite-app
bot
force-pushed
the
11-27-feat_linter_plugins_implement_options_merging
branch
from
d89782f to
3226864
Compare
Base automatically changed from
11-27-refactor_linter_plugins_split_json_deep_freeze_into_multiple_functions
to
main
November 27, 2025 22:38
graphite-app
bot
deleted the
11-27-feat_linter_plugins_implement_options_merging
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement function for merging rule options from config with the rule's default options.
This function is not currently used, as we don't have a way to get options from config over from Rust to JS yet, but I've implemented it now, as it's also needed for the rule tester (#16206).