perf(no-unnecessary-type-arguments): use isTypeIdenticalTo + flags checks#723
Merged
camc314 merged 3 commits intooxc-project:mainfrom Feb 22, 2026
Conversation
connorshea
reviewed
Feb 22, 2026
kalvenschraut
changed the title
camchenry
approved these changes
Feb 22, 2026
Member
camchenry
left a comment
camchenry
left a comment
There was a problem hiding this comment.
I think this makes sense: checking A < B and B < A should be the same as checking A == B, and that seems to correspond with the ts-eslint rule behavior too (i.e., doesn't report this rule even if the arg type is a subtype of the param type).
Collaborator
|
Wonderful! |
camc314
changed the title
camc314
changed the title
camc314
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI wrote this when trying to find why a rule was so slow against my company's internal codebase.
Before these changes
after